Add GCP support - #8
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the CI image pipeline with GCP support and adds a pre-build config validation job.
Config validation (
validate-configjob)A new
validate-configjob now runs before any image build. It checks outartemnikitin/fireworkat the ref pinned in repo variableFIREWORK_CONFIG_REF(falls back to commitbe5c449when the variable is unset, becausecmd/configcheckis not yet onfireworkmain). It runsgo run ./cmd/configcheck --require-remote-routingagainst the repository root, so a misconfigured runtime YAML fails fast without spending build minutes.GCS upload (
upload-gcsjob)A new
upload-gcsjob runs on pushes tomain, afterbuild. It:*-rootfs.ext4togs://$GCS_IMAGES_BUCKET/viamake push-gcsARM64 images continue to upload to S3 (
make push-s3). The split keeps amd64 and ARM64 image basenames in separate buckets so they cannot overwrite each other.push-images.shdual-backend supportscripts/push-images.shnow checksGCS_IMAGES_BUCKETfirst, thenS3_IMAGES_BUCKET. Exactly one must be set; the script exits non-zero if neither is provided.Provider-neutral routing
Tenant files now set
metadata.subdomain(one DNS label) instead ofmetadata.host(exact FQDN). The deployed agent'singress_domainforms<subdomain>.<ingress_domain>. This removes the AWS-only hostname assumption and works identically on GCP.