Update CI - #7
Merged
Merged
Conversation
The build-images workflow selects exactly one overlay directory (tenant-specific if it exists, otherwise shared) rather than applying both in layers. Update the README to match the actual either/or behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Previously the workflow selected only one overlay directory (tenant-specific if present, otherwise shared), so shared configs were silently skipped whenever a tenant-specific overlay existed. Change docker-to-rootfs.sh to accept a colon-separated list of overlay directories and apply them in order (later entries override earlier ones). Update the workflow to build the colon-separated path when both a shared and a tenant-specific overlay exist, so shared configs serve as the baseline and tenant-specific configs override them. Also update the README to reflect the correct layered behavior. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
configs/<service>/first, thenconfigs/<tenant>-<service>/on top.Makefileentrypoint.make buildon pull requests, and run bothmake buildandmake pushonly for pushes tomain.Details
scripts/build-images.shresolvesfc-init, reads tenant service YAML, computes overlay arguments, and builds all tenant rootfs images.scripts/push-images.shuploads generated*-rootfs.ext4artifacts to S3.scripts/docker-to-rootfs.shnow accepts colon-separated overlay directories and applies them in order.make buildandmake pushinstead of carrying the shell logic inline.