Repository navigation
Conversation
Zorienu
marked this pull request as ready for review
November 7, 2026 19:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review: one ignored test in
crates/core/src/tests.rs; no rendering code changes.What it adds
dump_brush_comparisonsimports a.brushset, draws each brush preview at its own thumbnail size, and writesprocreate.png,engine.png, and MAE/RMSE.comparison.png,overlay.png,comparison-3x.png, metrics, and a contact sheet.📂folder entries.Why
The #88 rewrite landed the preview fixes but not the comparison harness. This keeps the harness in the repo so future brush sets can be checked without rebuilding it.
Run
Output
<output>/<brush>/procreate.png— the set’s own thumbnail<output>/<brush>/engine.png— the engine-drawn preview<output>/summary.txt— ranked MAE/RMSEcomparison.png,overlay.png,comparison-3x.png— after the ImageMagick stepInvestigation note
The two images below are from the investigation, not a rendering change in this PR:
Columns: Procreate, current
main, candidate half-size texturized-grain tile. The middle column is closer to Procreate. The candidate lowered RMSE by changing pattern phase, not by making the texture look closer, so it was dropped from this PR. It is kept onexperiment/texturized-grain-halffor future work.Verify
cargo test -p procraft-engine: 387 passed, 0 failed.