Repository navigation
Conversation
…e showing the interface and canvas washed out Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On Linux (Wayland, Vulkan: Mesa RADV and NVIDIA 615), the whole window shows washed out in the dark interface. The surround that
SURROUNDsets to #252525 shows as #6A6A6A on screen (measured withgrim), and the bars and side bar are lifted the same way.frame::configuretakes the first non-sRGB format the surface offers. Through wgpu, that isRgba16Floaton these drivers (log:surface 1920×1080 Rgba16Float Mailbox Auto). The compositor reads a float surface as linear, but the colours drawn on it are already sRGB-encoded. 37/255 read as linear shows as 106/255, which is exactly what's on screen.Fix
Prefer
Bgra8Unorm, thenRgba8Unorm, where the surface offers them, and fall back to the old choice otherwise. They are still non-sRGB formats, so nothing is re-encoded, as the function's comment asks.Checked
Bgra8Unorm, and the surround measures exactly #252525 on screen.cargo check -p procraft-coreandcargo fmt --checkpass on main.🤖 Generated with Claude Code