Repository navigation
feat: add Arabic interface translation - #37
Merged
bearinmindcat merged 2 commits intoNov 3, 2026
Merged
bearinmindcat merged 2 commits into
bearinmindcat merged 2 commits into
Conversation
hussain-hz
marked this pull request as ready for review
October 28, 2026 11:43
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the Arabic interface catalog at values-ar/strings.xml, covering all 711 translatable resources in the current English catalog: 700 strings and 11 plurals. Each plural includes zero, one, two, few, many and other, with natural singular/dual wording.
The translation follows upstream wording and behavior. It keeps resource names, format argument types/positions, escapes, product names and technical identifiers intact. Preferences, notification text, read-only messages and the Show status bar option follow upstream wording and behavior. No fork-specific features, themes, engine changes or application identity changes are included.
The existing supportsRtl and generated locale config handle Arabic discovery and layout direction. A small icon-helper change enables autoMirror only for the four navigation arrows/chevrons so Back/Next and drill-in indicators follow RTL; rotation, alignment, drawing and media icons keep their physical directions. Generated locale config includes ar without manifest changes.
Validation completed:
Debug APK assembly succeeded. Focused Android localization lint completed with 0 errors and no Arabic-resource findings; its 11 MissingQuantity warnings are in the unchanged Spanish catalog. Full lint remains blocked by three existing errors in unchanged upstream files: SuspiciousIndentation (HomeScreen.kt:174), NonObservableLocale (ReadAloud.kt:631), and ContextCastToActivity (AppRoot.kt:87). Local validation used installed NDK 30 through an external init script; the repository's NDK configuration is unchanged.
Emulator review covered Arabic Home, Preferences, About/version formatting, PDF viewer and its menu, plus English/Arabic navigation-arrow direction. These checks do not cover every translated string or all application flows. The PR remains a draft for review.
Arabic interface screenshots
Captured from a debug build of this upstream contribution, with Arabic selected as the application language.