Skip to content

is_between: name the offending type of the end argument, not the start argument #1320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
HrachShah wants to merge 1 commit into
base: master
Choose a base branch
from
+11 −1
Open

is_between: name the offending type of the end argument, not the start argument #1320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion arrow/arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1525,7 +1525,7 @@ def is_between(
)

if not isinstance(end, Arrow):
raise TypeError(f"Cannot parse end date argument type of {type(start)!r}.")
raise TypeError(f"Cannot parse end date argument type of {type(end)!r}.")

include_start = bounds[0] == "["
include_end = bounds[1] == "]"
Expand Down
10 changes: 10 additions & 0 deletions tests/test_arrow.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3047,6 +3047,16 @@ def test_type_error_exception(self):
with pytest.raises(TypeError):
target.is_between(None, None)

def test_is_between_error_message_mentions_end_type(self):
target = arrow.Arrow.fromdatetime(datetime(2013, 5, 7))
start = arrow.Arrow.fromdatetime(datetime(2013, 5, 5))
end = datetime(2013, 5, 8)
with pytest.raises(TypeError) as excinfo:
target.is_between(start, end)
assert "end" in str(excinfo.value)
assert "datetime" in str(excinfo.value)
assert "Arrow" not in str(excinfo.value)

def test_value_error_exception(self):
target = arrow.Arrow.fromdatetime(datetime(2013, 5, 7))
start = arrow.Arrow.fromdatetime(datetime(2013, 5, 5))
Expand Down
Loading