fix: Feedback 3 follow-up — Support edit matrix, Assigned-to-me, queue filters - #41
Merged
Merged
Conversation
Assigned Support on site can update Support persons (same gate as internal notes); other internal fields stay read-only with server-side restore. Updates EN/DE notice and PHPUnit expectations for Spec 091. Co-authored-by: Cursor <cursoragent@cursor.com>
Rename Spec-065 wording and assert supportpersons is enabled for assigned Support on the event form (Spec 091). Co-authored-by: Cursor <cursoragent@cursor.com>
Moodle autocomplete hides the original select; treat the visible autocomplete UI as enabled/disabled so Support persons checks work. Co-authored-by: Cursor <cursoragent@cursor.com>
Include creator/PIC/other examiners/support in assignment filters, apply date/faculty/semester on Open/Confirmed/Rejected, and default Rejected to the full calendar year without changing All requests defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
Confirmed/rejected queue fixtures must not set usercreated to admin, or Spec-092 Assigned-to-me inflates the count beyond the support-only set. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop always-false queue_tab_ignores_reporting_params and the overview wipe branch so Request Workspace uses one live filter path (Spec 093); Spec 092 behaviour unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
…vents Expose Assigned-to-me on queue/history/myevents, apply involvement SQL once after workspace branches, and wire the Booker overview PHP filter path. Co-authored-by: Cursor <cursoragent@cursor.com>
Restrict status options to Cancelled+Rejected with server-side narrowing; keep Open/Confirmed without a status filter. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Extract iterated arrays to variables so Moodle phpcs and the MDC pre-commit formatter agree. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
queue_tab_ignores_reporting_paramshelper.foreach (into array variables so Moodle phpcs and MDC pre-commit agree.Test plan
moodlestack_r17299-bookit-webserver-1): phplint, phpcs, phpmd, phpdoc, validate, savepoints, mustache, grunt amd, phpunit (442 tests), behat (95 scenarios) — all PASSsusi.serviceteam: Rejected and cancelled status options = Cancelled+Rejected; Assignment present; Open/Confirmed have no status filterMade with Cursor