Feature/calendar dev - #40
Open
aro-ssystems wants to merge 134 commits into
Open
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Line 306: Split aria-label option array across multiple lines Line 315: Refactor help icon text into separate variables
This reverts commit af1af3a.
Render the Internal fields header for support users with restricted view access, expose refcourseid and extra times as read-only, and restore refcourseid on save when internal edit is not allowed. Co-authored-by: Cursor <cursoragent@cursor.com>
Extend get_reporting_default_range with history tab flag and wire overview navigation so All bookings keeps today-to-year-end while History uses 01.01 through end of today for service-team users. Co-authored-by: Cursor <cursoragent@cursor.com>
Add service-team Request Workspace with five tabs, tab-specific loaders and filters, unified workspace table with workflow history, and user-persistent column sort (mod_bookit_overview_sort) with newest-first server default. Co-authored-by: Cursor <cursoragent@cursor.com>
Add can_view_request_workspace() and split view vs manage gates so support on site sees all five workspace tabs and institutional lists without status changes or reactivate actions; extend PHPUnit coverage for access, queue, and API denial. Co-authored-by: Cursor <cursoragent@cursor.com>
Surgical lang edits for modulename*, optional fresh-install demo titles, and lang tests. Co-authored-by: Cursor <cursoragent@cursor.com>
Align DE nav strings with EN product name; replaces Anfragen-Workspace from 2026-05-19. Co-authored-by: Cursor <cursoragent@cursor.com>
Request-workspace navigation, DESC sort, and canonical tab URLs in Behat; PHPUnit expectations for rejected-queue sort and read parity. phpcs/mustache hygiene for OVERALL=0 (lang key order, test headers, workspace table context). Co-authored-by: Cursor <cursoragent@cursor.com>
Remove rejectedrequests/myevents alias normalization; add tab validation API, DRY overview filter partial, nav badge renderer, i18n columns, and mobile CSS. Align Behat suites with strict canonical tab enforcement. Co-authored-by: Cursor <cursoragent@cursor.com>
… 077-079) Replace queuepage with canonical Moodle page parameter across SSR, external APIs and AMD; add page-bounded SQL count/page reads for all workspace tabs. Co-authored-by: Cursor <cursoragent@cursor.com>
…s (Spec 080) Filter workflow history and latest-summary output server-side for overview.php, queue mapper and external refresh paths; omit entries with no visible fields. Co-authored-by: Cursor <cursoragent@cursor.com>
…nd filters (Spec 081) Resolve missing tab after role context, declare reactivation fields in External return schemas, align rejectedcancelled AJAX column order with SSR, and remove the legacy semester filter path. Co-authored-by: Cursor <cursoragent@cursor.com>
… 082) Replace hardcoded English table headers and progress mini-labels with existing overviewcolumn* context placeholders from overview.php. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace page-local custom sort/queue AJAX with persistent Core table sorting, global SQL order, and canonical status redirect. Co-authored-by: Cursor <cursoragent@cursor.com>
…ec 084) Stop mutating notification templates on admin settings load, drop unbounded list getters and calendar/tab alias fallbacks, and document canonical notification placeholders in EN/DE help text. Co-authored-by: Cursor <cursoragent@cursor.com>
…085) Replace the terminal-only history status default with the full five-status set so reporting History is not limited to Canceled and Rejected. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Include langfile QA fixes: valid nobookitinstances key, EN/DE cleanup and sort. Co-authored-by: Cursor <cursoragent@cursor.com>
Restore edit/sort lang strings, set usercreated in notification tests, harden resource entity test isolation, clarify ICS PHPDoc, align placeholders Behat with UI copy, and label Created by user correctly. Co-authored-by: Cursor <cursoragent@cursor.com>
Replace PHPStan-style array generics that local_moodlecheck treats as an incomplete @PARAM list for build_description_rows. Co-authored-by: Cursor <cursoragent@cursor.com>
Assigned Support on site can update Support persons (same gate as internal notes); other internal fields stay read-only with server-side restore. Updates EN/DE notice and PHPUnit expectations for Spec 091. Co-authored-by: Cursor <cursoragent@cursor.com>
Rename Spec-065 wording and assert supportpersons is enabled for assigned Support on the event form (Spec 091). Co-authored-by: Cursor <cursoragent@cursor.com>
Moodle autocomplete hides the original select; treat the visible autocomplete UI as enabled/disabled so Support persons checks work. Co-authored-by: Cursor <cursoragent@cursor.com>
Include creator/PIC/other examiners/support in assignment filters, apply date/faculty/semester on Open/Confirmed/Rejected, and default Rejected to the full calendar year without changing All requests defaults. Co-authored-by: Cursor <cursoragent@cursor.com>
Confirmed/rejected queue fixtures must not set usercreated to admin, or Spec-092 Assigned-to-me inflates the count beyond the support-only set. Co-authored-by: Cursor <cursoragent@cursor.com>
Drop always-false queue_tab_ignores_reporting_params and the overview wipe branch so Request Workspace uses one live filter path (Spec 093); Spec 092 behaviour unchanged. Co-authored-by: Cursor <cursoragent@cursor.com>
…vents Expose Assigned-to-me on queue/history/myevents, apply involvement SQL once after workspace branches, and wire the Booker overview PHP filter path. Co-authored-by: Cursor <cursoragent@cursor.com>
Restrict status options to Cancelled+Rejected with server-side narrowing; keep Open/Confirmed without a status filter. Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
Extract iterated arrays to variables so Moodle phpcs and the MDC pre-commit formatter agree. Co-authored-by: Cursor <cursoragent@cursor.com>
fix: Feedback 3 follow-up — Support edit matrix, Assigned-to-me, queue filters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.