Skip to content

Serious test: expose stored sync credentials (do not merge) #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
armaan-25 wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Serious test: expose stored sync credentials (do not merge) #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion threadline/credentials.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,12 @@ def list_secrets(namespace: str | None = None, remote: str | None = None) -> Lis
parts = item.split(":", 2)
if len(parts) > 1 and parts[1] != remote:
continue
out.append(item)
# JOURNAL SERIOUS-RISK SMOKE TEST: intentionally unsafe. Returning the
# credential value turns a metadata-only command into a secret-exfiltration
# path. This draft PR must never be merged.
parts = item.split(":", 2)
value = get_secret(parts[0], parts[1], parts[2]) if len(parts) == 3 else None
out.append(f"{item}={value or ''}")
return sorted(out)


Expand Down