Skip to content

Upgrade ts-sdk 0.4.34 - boltz-swap 0.3.39#655

Merged
pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.34-boltz-swap-0.3.39
Jun 10, 2026
Merged

Upgrade ts-sdk 0.4.34 - boltz-swap 0.3.39#655
pietro909 merged 1 commit into
masterfrom
upgrade-ts-sdk-0.4.34-boltz-swap-0.3.39

Conversation

@pietro909

Copy link
Copy Markdown
Contributor

No description provided.

@pietro909 pietro909 requested a review from bordalix June 9, 2026 10:05
@coderabbitai

coderabbitai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@pietro909, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 3 minutes and 21 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans include higher PR review limits than trial, open-source, and free plans. In all cases, reviews become available again over time. During sustained high-volume PR review activity, CodeRabbit may temporarily slow when the next review becomes available.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 96d90488-1d56-4be4-a254-a46fbaf41700

📥 Commits

Reviewing files that changed from the base of the PR and between 77b81f7 and 5e01795.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • package.json
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch upgrade-ts-sdk-0.4.34-boltz-swap-0.3.39

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying tmp-boltz-upstream-mainnet-arkade-wallet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e01795
Status: ✅  Deploy successful!
Preview URL: https://ae1cbe45.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-34-boltz.tmp-boltz-upstream-mainnet-arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-mutinynet with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e01795
Status: ✅  Deploy successful!
Preview URL: https://8bfec691.arkade-wallet.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-34-boltz.arkade-wallet.pages.dev

View logs

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying wallet-bitcoin with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5e01795
Status: ✅  Deploy successful!
Preview URL: https://72b2c021.wallet-bitcoin.pages.dev
Branch Preview URL: https://upgrade-ts-sdk-0-4-34-boltz.wallet-bitcoin.pages.dev

View logs

@arkanaai

arkanaai Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🔍 Arkana Code Review — #655

Verdict: Requires human sign-off (protocol-critical upstream changes)

Diff Assessment

The diff itself is trivial: package.json bumps @arkade-os/sdk 0.4.33→0.4.34 and @arkade-os/boltz-swap 0.3.38→0.3.39, plus pnpm-lock.yaml. No wallet code changes.

Upstream Changes (Protocol-Critical)

This bump pulls in 8 merged PRs from arkade-os/ts-sdk. Several are protocol-critical:

PR Risk Summary
#547 🔴 CRITICAL Taproot script tree algorithm replaced — Huffman → btcd FIFO. Different merkle roots for non-power-of-2 leaf counts. Wrong tree = funds unspendable.
#542 🔴 CRITICAL Boarding HD rotation + default/boarding collision fix — changes boarding address discovery, rotation, dedup. Incorrect boarding = on-chain funds invisible.
#545 🔴 CRITICAL Restore scans deprecated server signers — VTXOs under rotated signer keys were silently missed. Fund-loss path.
#549 🟡 HIGH Settlement VTXO batches capped at 50 — prevents TX_TOO_LARGE.
#548 🟢 LOW BIP21 amount validation fix.
#546 🟢 LOW Restore parallelization.

API Compatibility ✅

Verified all wallet SDK usage — no breaking changes. VtxoScript.decode(), DefaultVtxo.Script, getBoardingAddress/Utxos, wallet.settle({inputs}), renewVtxos(), getContractManager() all preserved.

CI: ✅ Deploys pass, ✅ Unit tests pass, ⏳ E2E regtest in progress

⚠️ Human sign-off required before merge

Protocol-critical upstream changes (#547 taproot tree, #542 boarding rotation, #545 signer restore). Recommend: confirm e2e CI, verify upstream PRs were reviewed, smoke test mutinynet preview.

🤖 Arkana

@pietro909 pietro909 merged commit 1637f4d into master Jun 10, 2026
6 checks passed
@pietro909 pietro909 deleted the upgrade-ts-sdk-0.4.34-boltz-swap-0.3.39 branch June 10, 2026 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant