Fix reauth UX: friendly entry title and dialog description - #53
Open
geert36 wants to merge 4 commits into
Open
Conversation
geert36
commented
Jul 2, 2026
geert36
commented
Contributor
- Set config entry title to "PostNL" instead of the raw client_id, both on first install and when re-authenticating
- Add config_flow strings for reauth_confirm step so the dialog shows a title and explanation instead of an empty form
- Set config entry title to "PostNL" instead of the raw client_id, both on first install and when re-authenticating - Add config_flow strings for reauth_confirm step so the dialog shows a title and explanation instead of an empty form Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Instead of HomeAssistantError (which logs a setup error), raise ConfigEntryAuthFailed so HA marks the entry as needing re-auth and presents the re-authentication flow to the user automatically. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Existing entries created before the friendly-title fix keep their client_id as title. Update the title at the start of async_setup_entry so it's corrected immediately on the next HA restart, even when setup fails before reaching async_oauth_create_entry. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The frontend reads from translations/{lang}.json, not strings.json.
Add en.json and nl.json so the reauth dialog shows a title and
description instead of an empty form.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.