Skip to content

chore: add release workflow docs and scripts - #5

Closed
vibbyfs wants to merge 1 commit into
mainfrom
codex/create-github-release-workflow-with-documentation
Closed

chore: add release workflow docs and scripts#5
vibbyfs wants to merge 1 commit into
mainfrom
codex/create-github-release-workflow-with-documentation

Conversation

@vibbyfs

@vibbyfs vibbyfs commented Aug 28, 2025

Copy link
Copy Markdown
Contributor

Summary

  • document branching strategy and release flow
  • add pull request template and linear history check workflow
  • add release helper scripts and version marker

Testing

  • npm test (fails: Missing script: "test")
  • bash scripts/release/mark-main.sh (fails: This script must run on main. Current: work)

https://chatgpt.com/codex/tasks/task_e_68afe672859c832b8af369376eee5230

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Codex Review: Here are some suggestions.

Reply with @codex fix comments to fix any unresolved comments.

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Comment on lines +16 to +18
- name: Ensure no merge commits
run: |
git fetch origin main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Linear history workflow flags every PR

The workflow checks for merge commits with git rev-list --merges origin/main..HEAD, but on pull_request events actions/checkout leaves HEAD on GitHub’s synthetic refs/pull/<id>/merge commit, which is itself a merge commit. As a result the check fails even when the head branch contains only rebased commits, blocking all releases to main. Consider checking origin/main..origin/${{ github.head_ref }} or checking out github.head_ref to avoid the synthetic merge.

Useful? React with 👍 / 👎.

Comment on lines +18 to +19
git checkout main
git pull origin main

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[P1] Release script never pushes marker commit

After merging development into main, the script runs mark-main.sh which creates a local commit bumping VERSION and CHANGELOG, but the script exits without pushing main back to origin. Every run will therefore leave the release marker only in the local clone and the remote branch stays unchanged, so the release history on GitHub is never updated.

Useful? React with 👍 / 👎.

@vibbyfs vibbyfs closed this Aug 28, 2025
@vibbyfs
vibbyfs deleted the codex/create-github-release-workflow-with-documentation branch August 28, 2025 05:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant