chore: add release workflow docs and scripts - #5
Conversation
There was a problem hiding this comment.
Codex Review: Here are some suggestions.
Reply with @codex fix comments to fix any unresolved comments.
About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".
| - name: Ensure no merge commits | ||
| run: | | ||
| git fetch origin main |
There was a problem hiding this comment.
[P1] Linear history workflow flags every PR
The workflow checks for merge commits with git rev-list --merges origin/main..HEAD, but on pull_request events actions/checkout leaves HEAD on GitHub’s synthetic refs/pull/<id>/merge commit, which is itself a merge commit. As a result the check fails even when the head branch contains only rebased commits, blocking all releases to main. Consider checking origin/main..origin/${{ github.head_ref }} or checking out github.head_ref to avoid the synthetic merge.
Useful? React with 👍 / 👎.
| git checkout main | ||
| git pull origin main |
There was a problem hiding this comment.
[P1] Release script never pushes marker commit
After merging development into main, the script runs mark-main.sh which creates a local commit bumping VERSION and CHANGELOG, but the script exits without pushing main back to origin. Every run will therefore leave the release marker only in the local clone and the remote branch stays unchanged, so the release history on GitHub is never updated.
Useful? React with 👍 / 👎.
Summary
Testing
npm test(fails: Missing script: "test")bash scripts/release/mark-main.sh(fails: This script must run on main. Current: work)https://chatgpt.com/codex/tasks/task_e_68afe672859c832b8af369376eee5230