ci(security): adopt reusable workflows from 2026-08-16 - #92
Merged
Conversation
The tag carries the concurrency discriminator that keeps the CodeQL job from being cancelled against this workflow's own group, and the `go-version-file` input that replaces the hand-synced literal version. Signed-off-by: Simon Bärlocher <s.baerlocher@sbaerlocher.ch>
Dependency ReviewThe following issues were found:
License Issues.github/workflows/nightly-security.yml
OpenSSF Scorecard
Scanned Files
|
There was a problem hiding this comment.
No issues found.
The change is a clean, self-consistent maintenance update to .github/workflows/nightly-security.yml:
- All three reusable-workflow refs bump
@2026-08-15→@2026-08-16consistently (no version skew). - The explicit
go-version: "1.26.6"input and its comment are removed from thecodeqljob. Removing the pin together with the comment that said the reusable workflow "only accepts a literal version, not a go-version-file" — in the same commit that bumps the reusable workflow tag — indicatessecurity-code.yml@2026-08-16now auto-detects the Go toolchain (e.g. fromgo.mod, which declaresgo 1.26.6).
Note: the arillso/.github reusable workflow at @2026-08-16 is not accessible from the review sandbox, so its default/detected Go version could not be independently confirmed. If that workflow does not read go.mod, please verify the nightly CodeQL Go extraction still builds against the 1.26.6 module directive.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Picks up two fixes from
arillso/.github#111:security-code.ymlhad aconcurrencygroup of bare${{ github.workflow }}-${{ github.ref }}. Inside aworkflow_callreusable those resolve to the caller, so the group was byte-identical to the one this workflow declares for itself, and withcancel-in-progressdefaulting totruethe job was dropped at scheduling time. That is why the nightly scan has reportedfailuresince 2026-08-12 with every job it created green, no annotation and no log — the job never existed.go-versionliteral. The reusable now takes ago-version-fileinput defaulting togo.mod, so the version no longer has to be repeated here and kept in sync by hand. That manual sync point is what let the Go 1.26.5 stdlib advisories sit unnoticed in the CodeQL job.Test plan
codeql / Analyze Code (go)is created and executes, where onmainit is absent from the jobs list entirely