Better support of pre-2.7 ruby#511
Merged
Merged
Conversation
TApplencourt
force-pushed
the
better-support-of-pre-2.6-ruby
branch
2 times, most recently
from
c91200b to
de501a0
Compare
iprof (xprof.rb) uses modern ruby syntax (endless ranges), so an old ruby fails to *parse* the whole file before the version check can run, giving a raw SyntaxError instead of a friendly message. Split iprof into a tiny old-ruby-safe wrapper (xprof_wrapper.rb.in -> bin/iprof) that checks the ruby version, then requires the implementation (xprof.rb, now in DATADIR). The wrapper uses only old, plain syntax, so the version gate runs and prints a friendly message on old ruby. Also add a configure-time ruby >= 2.7 check (single-sourced via RUBY_MIN_VERSION) and a bats regression test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
TApplencourt
force-pushed
the
better-support-of-pre-2.6-ruby
branch
from
de501a0 to
73ac13e
Compare
Collaborator
Author
|
Amazing PR Thomas! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
iprof (xprof.rb) uses modern ruby syntax (endless ranges), so an old ruby fails to parse the whole file before the version check can run, giving a raw SyntaxError instead of a friendly message.
Split iprof into a tiny old-ruby-safe wrapper (xprof_wrapper.rb.in -> bin/iprof) that checks the ruby version, then requires the implementation (xprof.rb, now in DATADIR). The wrapper uses only old, plain syntax, so the version gate runs and prints a friendly message on old ruby.
Also add a configure-time ruby >= 2.7 check (single-sourced via RUBY_MIN_VERSION) and a bats regression test.