Add /v2/mounts and /v2/mounts/skins#583
Open
darthmaim wants to merge 1 commit into
Open
Conversation
darthmaim
force-pushed
the
add-mounts
branch
from
November 14, 2017 23:34
4df22f9 to
2f859e6
Compare
darthmaim
force-pushed
the
add-mounts
branch
from
November 14, 2017 23:36
2f859e6 to
0e2413f
Compare
apoch
suggested changes
Dec 5, 2018
apoch
left a comment
Contributor
There was a problem hiding this comment.
These endpoints have been implemented (as /v2/mounts/types and /v2/mounts/skins). We can either update the API doc in-house, or if you'd like, feel free to update this PR with the current endpoint description and I'll be happy to merge it in. Thanks!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We haven't mentioned mounts here on github yet, so I thought I would go ahead and make a PR.
This adds /v2/mounts and /v2/mounts/skins.
Not sure if mixing string ids and subendpoints is the best idea, maybe /v2/mount/types and /v2/mount/skins are better?
Not included in this PR (yet?) are additional fields in /v2/account returning unlocked mounts and /v2/characters returning the equipped skins and dye channels (see also #610).