Add /v2/account/contacts.#275
Open
lye wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm not entirely convinced I like the "split into different endpoints" approach. Might make more sense to have them separated? The main reason I wanted them split is because I have like 500+ goldsellers blocked and don't really care about that overhead when I'm just pulling down my friends list (e.g., to rate my account against theirs on various sites).
This doesn't expose presence data (e.g., the offline/online/map location bits). Will open a separate issue for that.
Also should note that this adds a new permission, "contacts", which provides access to this endpoint. Need to figure out what other things that might grant access to (so we avoid permission overload).
refs #270