Fix sslinfo test behavior and increase info size#2659
Open
bimboterminator1 wants to merge 1 commit into
Open
Conversation
Commit 5d1833f statrted to use be_tls_* API for SSL information in sslinfo in extensions functions. It trims expected string produced by X509_get_subject_name at NAMEDATALEN (64) length. Vanila postgres does not have tests for sslinfo at all, they were introduced in GPDB. Thus, we could either return the full string or leave the upsteam variant. Since the motivation behind upstream commit is refactoring, we could try to increase the symbol limits.
Member
|
How can this be tested? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 5d1833f statrted to use be_tls_* API for SSL information in sslinfo
in extensions functions. It trims expected string produced by
X509_get_subject_name at NAMEDATALEN (64) length. Vanila postgres does not have
tests for sslinfo at all, they were introduced in GPDB. Thus, we could either
return the full string or leave the upsteam variant. Since the motivation behind
upstream commit is refactoring, we could try to increase the symbol limits.