fix(clippy): allow chunks_exact_to_as_chunks (CI rust 1.98, MSRV 1.85) - #159
Closed
cunninghamcard-bit wants to merge 1 commit into
Closed
fix(clippy): allow chunks_exact_to_as_chunks (CI rust 1.98, MSRV 1.85)#159cunninghamcard-bit wants to merge 1 commit into
cunninghamcard-bit wants to merge 1 commit into
Conversation
… is 1.85) The 1.98 lint suggests as_chunks::<8>(), which stabilized in 1.88 and is therefore unavailable at the workspace MSRV of 1.85. Same pattern as the 1.97 collapsible_if allowance.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI's Rust 1.98 clippy added
chunks_exact_to_as_chunks, which fails-D warningsonaimux-core/src/trace/hash.rsand currently breaks every PR's Rust core job. The suggestedas_chunks::<8>()stabilized in Rust 1.88, above the workspace MSRV of 1.85, so this follows the existing precedent (the 1.97collapsible_ifallowance) and adds a scoped#[allow]with a note to drop it once the MSRV moves past 1.88.