feat(vue-docx): add showUpload and showDownload props - #3
Merged
eric8810 merged 2 commits intoJul 24, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds
showUploadandshowDownloadprops toDocxViewerso read-only preview hosts can hide the upload and download entry points independently, instead of dropping the entire toolbar viashowToolbar.true, so existing behavior is unchanged.showUpload: falsealso hides the empty-state "Choose Word file" and error-state "Choose another Word file" buttons, since they open the same local file picker as the toolbar button.XlsxViewershowUploadconvention.showToolbar,showUpload,showDownload,defaultThumbnailsOpen,isDarkanddefaultZoomas live toggles.defaultThumbnailsOpenis folded into the viewer key because it is only read on mount.Commits
feat(vue-docx): add showUpload and showDownload props— component, toolbar, docs, CHANGELOG, component testsfeat(demo): add a props panel to the DocxViewer page— demo-onlyTest plan
tests/component/vue-components.test.mjs: default visibility, both props hidden with the toolbar still rendering, and the error state with onlyshowUploaddisabled (download button retained).Closes #2