fix(labels): wire model labels to the backend SiteLabel API - #105
Open
geourjoa wants to merge 3 commits into
Open
fix(labels): wire model labels to the backend SiteLabel API#105geourjoa wants to merge 3 commits into
geourjoa wants to merge 3 commits into
Conversation
model-labels-server.ts read/wrote a local config/model-labels.json file, completely bypassing apps.common.SiteLabel and its /api/v1/site-labels/ endpoint (backend#139) — so backoffice edits to that table never reached the rendered site. Point readModelLabels/writeModelLabels at the backend instead, and align the footer keys to the backend's Key enum (footerLine1/footerLine2/footerBottomLine) since it hard-rejects unknown keys on write. footer.tsx still references the old footerFunded/footerCopyright keys — left for a follow-up since it needs to decide how to lay out 3 lines instead of 2. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
geourjoa
force-pushed
the
fix/wire-model-labels-to-backend
branch
from
August 4, 2026 14:50
e55eb8e to
5b0bdfc
Compare
geourjoa
force-pushed
the
fix/wire-model-labels-to-backend
branch
from
August 5, 2026 05:11
e9cc87b to
d959e42
Compare
geourjoa
force-pushed
the
fix/wire-model-labels-to-backend
branch
from
August 5, 2026 08:04
fc3abc5 to
5ccafb8
Compare
geourjoa
marked this pull request as ready for review
August 5, 2026 08:06
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull request overview
Wires the frontend “model labels” system to read/write label values from the backend SiteLabel API (instead of a local JSON config), and updates the footer + backoffice translations UI to use the new footer label keys.
It's a PR to fix afterward internationalization stuff. Sorry for that. If not merged, all the translations stuff editable from backoffice will be not persistent on container restart.
Changes:
/api/v1/site-labels/(with SSR-safe fallback to defaults).Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
apiFetch/authFetch.footerLine1,footerLine2, andfooterBottomLine.