feat: add AppSettings model for centralized configuration - #148
Draft
geourjoa wants to merge 2 commits into
Draft
Conversation
Adds a per-key AppSettings model in apps.common, separate from SiteLabel, for backend/operational config. value is a plain TextField (not JSONField) since some entries are JSON-encoded strings that callers decode themselves. Registered for audit tracking alongside SiteLabel since register_audited_models works generically for any model.
This was referenced Aug 5, 2026
AppSettings.__str__ returned self.key (a CharField descriptor typed as Any) directly instead of wrapping it in str() like SiteLabel.__str__ already does, tripping mypy's no-any-return check in CI's lint job. Also bumps cryptography>=49.0.0 -> >=50.0.0: CI's dependency-audit job flags PYSEC-2026-3552 against 49.0.0, fixed in 50.0.0.
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add a table to centralize app settings. (Like enabled site feature and future improvement)
AppSettingsmodel (key/value/description/is_active/timestamps) toapps/common/models.py.SiteLabel(We can discuss to merge it but for me it's different concept)