Conversation
refactor: add page level detect and remove feature
There was a problem hiding this comment.
Pull Request Overview
This PR fixes IRQ settings in the ARMv8 hypervisor implementation by refactoring the VTCR_EL2 configuration, improving IRQ handling, and cleaning up dependencies.
- Replaces conditional compilation for EPT paging with runtime VTCR_EL2 probing
- Fixes IRQ/FIQ handling by properly configuring HCR_EL2 settings
- Removes unused dependencies and cleans up imports
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/vcpu.rs | Refactors VTCR_EL2 setup with runtime probing and fixes IRQ configuration |
| src/pcpu.rs | Removes hardcoded IRQ/FIQ settings from hardware enable |
| src/exception_utils.rs | Simplifies imports by using wildcard import |
| Cargo.toml | Reorganizes metadata and removes unused tock-registers dependency |
| .cargo/config.toml | Adds build target configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
base on arceos-hypervisor/axvcpu#38