Fix managed model settings, worker launch and Git LFS - #230
Open
gerred wants to merge 211 commits into
Open
Conversation
added 30 commits
August 24, 2026 15:12
# Conflicts: # crates/nac-core/src/session_service.rs # crates/nac-server/assets/dist/assets/markdown-renderer-FOg6yEwV.js # crates/nac-server/assets/dist/assets/markdown-renderer-TuCYxv9g.js # crates/nac-server/assets/dist/assets/markdown-renderer-os-ZjXyJ.js # crates/nac-server/assets/dist/index.html # crates/nac-server/src/fork.rs # crates/nac-server/src/lib.rs
…demo # Conflicts: # crates/nac-server/assets/dist/assets/index-BJXcjxU7.js # crates/nac-server/assets/dist/index.html
gerred
requested review from
Cecocho,
Crystalcareai,
eric-tramel and
sapiosaturn
as code owners
September 8, 2026 01:29
allisoneer
force-pushed
the
allison-demo
branch
2 times, most recently
from
September 8, 2026 15:42
fc59c4c to
90e04e4
Compare
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Managed hosts can launch with an injected model credential but cannot save existing-session Settings without an environment-variable selector. Worker launches also put managed flags before
__worker, causing CLI rejection, and mounted home directories lack Git LFS support.This fixes Settings and model-index discovery using the mounted key only for the exact operator-configured backend and endpoint, retaining the deployment default model. It corrects worker argument ordering and installs system Git LFS filters with offline push/clone/hydration smoke. The permission prompt explains why broad executable requests can only be approved once; permission scope remains unchanged. Embedded UI is rebuilt.
Stacked on Allison’s open #224 (
allison-demo) at070b5f0cfa16ab6276d50eae485fa91de772f353. Her branch is unchanged. Bootstrap recovery proof8710617is already an ancestor. Private image publication remains inmanaged-nac-controller; public NAC CI only builds and smokes.Validation: 159 server library, 23 CLI, 11 worker, 30 permission, 20 managed and 248 web tests; 18 production-embedded browser journeys; Rust/web lint, typecheck, formatting, API/source/image contracts and offline Git LFS transfer passed. The final Settings test also verifies destination/selector rejection leaves stored settings unchanged and missing mounted credentials fail closed. Local Docker is unavailable, so actual image build/smoke requires CI. No image was published and no infrastructure or live users were changed.
After review, merge this stack into #224 (or retarget after #224 merges). The controller release PR pins this exact fix commit; successful private publication and separate approved Flux promotion are still required before deployment.
Release dependency: https://github.com/arcee-ai/managed-nac-controller/pull/9. Flux promotion handoff: https://github.com/arcee-ai/flux-k8s-infra/pull/102.