xAI SuperGrok OAuth - #199
Conversation
|
All contributors have signed the CLA ✍️ ✅ |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Want higher recall? High effort reviews run extra passes and find more bugs. A team admin can switch effort levels in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 6ff873b. Configure here.
| self.prompt_cache_key.as_deref(), | ||
| ); | ||
|
|
||
| if self.backend == BackendKind::XaiAuth { |
There was a problem hiding this comment.
Trailing slash breaks inference URL
Medium Severity
validate_base_url accepts a trailing slash on the managed SuperGrok base path, and the docs describe that as valid, but send_openai_responses builds the request URL with a raw {base}/responses join. A configured https://api.x.ai/v1/ therefore becomes https://api.x.ai/v1//responses. Model discovery already trims trailing slashes, so listing can succeed while inference fails.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 6ff873b. Configure here.
There was a problem hiding this comment.
Join is untrimmed, so a configured https://api.x.ai/v1/ becomes /v1//responses. Default materialization is https://api.x.ai/v1. Live probe: both paths return 401 no-credentials, not 404. Listing vs inference URL shape differs. Inference does not fail.
|
I have read the CLA Document and I hereby sign the CLA |
1 participant
No description provided.