Skip to content

Remove usage of ItemTypeMng in ItemTypeInfo - #2841

Merged
grospelliergilles merged 4 commits into
mainfrom
dev/gg-remove-usage-of-itemtypemng-in-itemtypeinfo
Oct 23, 2026
Merged

grospelliergilles merged 4 commits into
mainfrom
dev/gg-remove-usage-of-itemtypemng-in-itemtypeinfo

Conversation

@grospelliergilles

Copy link
Copy Markdown
Member

This will allow to create custom temporary types (for polyhedrons for example) without using ItemTypeMng.

@grospelliergilles grospelliergilles self-assigned this Oct 23, 2026
@grospelliergilles grospelliergilles added arcane Arcane Component refactoring Code refactoring and cleanup labels Oct 23, 2026
@sonarqubecloud

Copy link
Copy Markdown

@codecov

codecov Bot commented Oct 23, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 96.77419% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 71.46%. Comparing base (4880b10) to head (1ad7103).
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
arcane/src/arcane/core/ItemTypeInfoBuilder.cc 91.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2841      +/-   ##
==========================================
- Coverage   71.49%   71.46%   -0.04%     
==========================================
  Files        2579     2579              
  Lines      195157   195151       -6     
  Branches    23174    23169       -5     
==========================================
- Hits       139537   139458      -79     
- Misses      46971    47033      +62     
- Partials     8649     8660      +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@grospelliergilles
grospelliergilles merged commit f2b65bf into main Oct 23, 2026
38 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

arcane Arcane Component refactoring Code refactoring and cleanup

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant