Skip to content

🛡️ Sentinel: [MEDIUM] Add timeout configurations to external fetch calls - #39

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeout-enhancement-2333203885143306407
Open

🛡️ Sentinel: [MEDIUM] Add timeout configurations to external fetch calls#39
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeout-enhancement-2333203885143306407

Conversation

@felirami

@felirami felirami commented Jul 3, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: Missing timeout configurations on external fetch calls to GitHub API and Dexscreener API, which can lead to hanging requests and resource exhaustion.
🎯 Impact: Server connections and resources could be tied up indefinitely if external services are unresponsive, potentially leading to denial of service or degraded performance in Next.js API routes and background sync scripts.
🔧 Fix: Implemented AbortSignal.timeout(TIMEOUT_MS) across all native fetch calls making external requests to enforce explicit time limits.
✅ Verification: Ran npm run lint, npm run typecheck, and npm run build to confirm no compilation issues were introduced. Checked the implementation of AbortSignal in network, market, and sync modules.


PR created automatically by Jules for task 2333203885143306407 started by @felirami


Note

Low Risk
Small, defensive changes that cap outbound request duration; failures should surface as existing timeout/error handling without changing API contracts.

Overview
Adds explicit fetch timeouts so hung GitHub, node probe, and Dexscreener calls cannot hold connections open indefinitely.

scripts/sync-sources.mjs defines GITHUB_FETCH_TIMEOUT_MS (30s) and passes AbortSignal.timeout(...) on both GitHub JSON and raw text helpers. getNetworkStatus in src/lib/network.ts now uses the existing NODE_PROBE_TIMEOUT_MS on its info probe (node health checks already timed out). getSnapMarketData in src/lib/snap-market.ts adds a 10s timeout for Dexscreener.

Documents the pattern in .jules/sentinel.md for future reviews.

Reviewed by Cursor Bugbot for commit 6f696f5. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Add timeouts to external fetch requests

What Changed

  • External requests to GitHub, Dexscreener, and the node status probe now stop after a set time instead of hanging indefinitely.
  • Background sync requests to GitHub use a 30-second limit, market data requests use a 10-second limit, and the existing node probe timeout is now applied to the status check.
  • Added a note for future reviews explaining that external fetch calls should always have explicit time limits.

Impact

✅ Fewer stuck API requests
✅ Lower risk of resource exhaustion during sync jobs
✅ More reliable market and network status checks

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add 30s and 10s AbortSignal timeouts to external fetch calls

  • Adds signal: AbortSignal.timeout(GITHUB_FETCH_TIMEOUT_MS) (30s) to fetchGithubJson and fetchGithubText in sync-sources.mjs
  • Adds a 10s timeout to getSnapMarketData in snap-market.ts via a new SNAP_MARKET_TIMEOUT_MS constant
  • Adds a timeout to the network status probe in getNetworkStatus using the existing NODE_PROBE_TIMEOUT_MS constant in network.ts
  • Documents the pattern in sentinel.md as a prevention guideline
  • Behavioral Change: fetch calls that previously hung indefinitely will now abort and throw a timeout error after the configured limit

Macroscope summarized 6f696f5.

🚨 Severity: MEDIUM
💡 Vulnerability: Missing timeout configurations on external fetch calls to GitHub API and Dexscreener API, which can lead to hanging requests and resource exhaustion.
🎯 Impact: Server connections and resources could be tied up indefinitely if external services are unresponsive, potentially leading to denial of service or degraded performance in Next.js API routes and background sync scripts.
🔧 Fix: Implemented AbortSignal.timeout(TIMEOUT_MS) across all native fetch calls making external requests to enforce explicit time limits.
✅ Verification: Ran `npm run lint`, `npm run typecheck`, and `npm run build` to confirm no compilation issues were introduced. Checked the implementation of AbortSignal in network, market, and sync modules.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jul 3, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jul 3, 2026 9:15pm

Request Review

@codeant-ai

codeant-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai

codeant-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:S This PR changes 10-29 lines, ignoring generated files label Jul 3, 2026
@codeant-ai

codeant-ai Bot commented Jul 3, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:S This PR changes 10-29 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant