Skip to content

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests - #38

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-add-fetch-timeouts-6861172879983958042
Open

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests#38
felirami wants to merge 1 commit into
mainfrom
sentinel-add-fetch-timeouts-6861172879983958042

Conversation

@felirami

@felirami felirami commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: Missing timeouts on external fetch calls. Native fetch lacks a default timeout, which means requests to slow or hanging external endpoints (INFO_ENDPOINT, dexscreenerApiUrl) can hang indefinitely, potentially exhausting server resources or severely degrading response times for end-users.
🎯 Impact: Prevents resource exhaustion and unexpected hanging processes, improving reliability and preventing a potential Denial of Service (DoS) caused by hanging promises.
🔧 Fix: Added signal: AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS) to getNetworkStatus in src/lib/network.ts and introduced SNAP_MARKET_TIMEOUT_MS = 10_000 to apply signal: AbortSignal.timeout(SNAP_MARKET_TIMEOUT_MS) in src/lib/snap-market.ts.
Verification: Verified via npm run build, npm run lint, and npm run typecheck that changes introduce no compilation or logic errors. Ensure error handling surfaces standard fetch timeout errors correctly.


PR created automatically by Jules for task 6861172879983958042 started by @felirami


Note

Low Risk
Small, defensive change to outbound HTTP with existing error handling; no auth, payment, or data-model changes.

Overview
Adds 10s abort signals to two server-side fetch calls that previously could hang indefinitely if an external endpoint stalled.

getNetworkStatus now uses the existing NODE_PROBE_TIMEOUT_MS via AbortSignal.timeout, aligning the public node info probe with node health checks that already used that limit. getSnapMarketData gets a new SNAP_MARKET_TIMEOUT_MS (10s) on the Dexscreener request. Failures still flow through existing catch paths (e.g. network status maps timeouts to a user-facing message via errorMessage).

Reviewed by Cursor Bugbot for commit 9534bfd. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Stop external status and market data requests from hanging indefinitely

What Changed

  • Network status checks now stop after a timeout instead of waiting forever for a slow or stalled endpoint
  • Snap market data requests now fail after 10 seconds if the external pricing service does not respond
  • Existing error handling still applies when either request times out or fails

Impact

✅ Fewer hanging status checks
✅ Lower chance of stalled page data
✅ More reliable external API calls

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add timeouts to external fetch requests in getNetworkStatus and getSnapMarketData

  • Adds AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS) to the fetch in getNetworkStatus; on timeout the function returns ok: false with the error message.
  • Adds a SNAP_MARKET_TIMEOUT_MS constant (10,000ms) and applies it via AbortSignal.timeout to the Dexscreener fetch in getSnapMarketData; on timeout the function returns ok: false with the error message.
  • Behavioral Change: both functions previously could hang indefinitely on slow or unresponsive endpoints; they now abort after their respective timeouts.

Macroscope summarized 9534bfd.

Adds explicit timeouts using `AbortSignal.timeout` to external `fetch` calls in network status and market data fetching to prevent potential resource exhaustion from hanging API responses.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codeant-ai

codeant-ai Bot commented Jul 2, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai

codeant-ai Bot commented Jul 2, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@vercel

vercel Bot commented Jul 2, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jul 2, 2026 8:58pm

Request Review

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jul 2, 2026
@codeant-ai

codeant-ai Bot commented Jul 2, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant