🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests - #38
🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests#38felirami wants to merge 1 commit into
Conversation
Adds explicit timeouts using `AbortSignal.timeout` to external `fetch` calls in network status and market data fetching to prevent potential resource exhaustion from hanging API responses. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CodeAnt AI finished reviewing your PR. |
User description
🚨 Severity: MEDIUM
💡 Vulnerability: Missing timeouts on external
fetchcalls. Nativefetchlacks a default timeout, which means requests to slow or hanging external endpoints (INFO_ENDPOINT,dexscreenerApiUrl) can hang indefinitely, potentially exhausting server resources or severely degrading response times for end-users.🎯 Impact: Prevents resource exhaustion and unexpected hanging processes, improving reliability and preventing a potential Denial of Service (DoS) caused by hanging promises.
🔧 Fix: Added
signal: AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)togetNetworkStatusinsrc/lib/network.tsand introducedSNAP_MARKET_TIMEOUT_MS = 10_000to applysignal: AbortSignal.timeout(SNAP_MARKET_TIMEOUT_MS)insrc/lib/snap-market.ts.✅ Verification: Verified via
npm run build,npm run lint, andnpm run typecheckthat changes introduce no compilation or logic errors. Ensure error handling surfaces standard fetch timeout errors correctly.PR created automatically by Jules for task 6861172879983958042 started by @felirami
Note
Low Risk
Small, defensive change to outbound HTTP with existing error handling; no auth, payment, or data-model changes.
Overview
Adds 10s abort signals to two server-side
fetchcalls that previously could hang indefinitely if an external endpoint stalled.getNetworkStatusnow uses the existingNODE_PROBE_TIMEOUT_MSviaAbortSignal.timeout, aligning the public node info probe with node health checks that already used that limit.getSnapMarketDatagets a newSNAP_MARKET_TIMEOUT_MS(10s) on the Dexscreener request. Failures still flow through existingcatchpaths (e.g. network status maps timeouts to a user-facing message viaerrorMessage).Reviewed by Cursor Bugbot for commit 9534bfd. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Stop external status and market data requests from hanging indefinitely
What Changed
Impact
✅ Fewer hanging status checks✅ Lower chance of stalled page data✅ More reliable external API calls💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add timeouts to external fetch requests in
getNetworkStatusandgetSnapMarketDataAbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)to the fetch ingetNetworkStatus; on timeout the function returnsok: falsewith the error message.SNAP_MARKET_TIMEOUT_MSconstant (10,000ms) and applies it viaAbortSignal.timeoutto the Dexscreener fetch ingetSnapMarketData; on timeout the function returnsok: falsewith the error message.Macroscope summarized 9534bfd.