🛡️ Sentinel: [MEDIUM] Add timeout to external API calls - #35
Conversation
Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
User description
🚨 Severity: MEDIUM
💡 Vulnerability: Unbounded external
fetchrequests can lead to resource exhaustion and potential Denial of Service (DoS) when endpoints take indefinitely long to respond, sincefetchlacks a default timeout.🎯 Impact: If
hypersnap.orgAPIs or network nodes hang or slow down, the background fetch requests in Next.js backend/SSR execution would hang indefinitely, exhausting worker limits and resources.🔧 Fix: Added
signal: AbortSignal.timeout(TIMEOUT_MS)to external fetch calls insrc/lib/network.tsandsrc/lib/snap-market.ts, using a pre-existing constant or setting a safe 10,000ms threshold.✅ Verification: Validated by running
npm run lint,npm run typecheck, andnpm run buildwhich complete successfully, verifying the code matches TypeScript types and node.js environments.PR created automatically by Jules for task 12706062347048855249 started by @felirami
Note
Low Risk
Small, defensive change with no auth or data-model impact; worst case is slightly earlier failures when upstreams exceed 10s.
Overview
Adds
AbortSignal.timeoutto two SSR/backgroundfetchcalls that previously had no upper bound on wait time.getNetworkStatusnow aborts after the existingNODE_PROBE_TIMEOUT_MS(10s).getSnapMarketDatagets a newSNAP_MARKET_TIMEOUT_MS(10s) on the Dexscreener request. Slow or hung upstreams should fail fast instead of holding Next.js workers open; existingcatchpaths still return error-shaped responses (including timeout messaging whereerrorMessageapplies).Reviewed by Cursor Bugbot for commit b366e61. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Stop hanging on slow external API calls
What Changed
Impact
✅ Fewer stuck status checks✅ Faster failure on slow third-party APIs✅ Lower chance of worker exhaustion from hanging requests💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add timeouts to external API calls in
getNetworkStatusandgetSnapMarketDataAbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)to thefetchcall innetwork.ts; on timeout,getNetworkStatusreturnsok: falsewith the error message.SNAP_MARKET_TIMEOUT_MSconstant (10,000ms) and applies it viaAbortSignal.timeoutto the Dexscreener fetch insnap-market.ts; on timeout,getSnapMarketDatareturnsok: falsewith the error message.Macroscope summarized b366e61.