Skip to content

🛡️ Sentinel: [MEDIUM] Add timeout to external API calls - #35

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-add-fetch-timeouts-12706062347048855249
Open

🛡️ Sentinel: [MEDIUM] Add timeout to external API calls#35
felirami wants to merge 1 commit into
mainfrom
sentinel-add-fetch-timeouts-12706062347048855249

Conversation

@felirami

@felirami felirami commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: Unbounded external fetch requests can lead to resource exhaustion and potential Denial of Service (DoS) when endpoints take indefinitely long to respond, since fetch lacks a default timeout.
🎯 Impact: If hypersnap.org APIs or network nodes hang or slow down, the background fetch requests in Next.js backend/SSR execution would hang indefinitely, exhausting worker limits and resources.
🔧 Fix: Added signal: AbortSignal.timeout(TIMEOUT_MS) to external fetch calls in src/lib/network.ts and src/lib/snap-market.ts, using a pre-existing constant or setting a safe 10,000ms threshold.
Verification: Validated by running npm run lint, npm run typecheck, and npm run build which complete successfully, verifying the code matches TypeScript types and node.js environments.


PR created automatically by Jules for task 12706062347048855249 started by @felirami


Note

Low Risk
Small, defensive change with no auth or data-model impact; worst case is slightly earlier failures when upstreams exceed 10s.

Overview
Adds AbortSignal.timeout to two SSR/background fetch calls that previously had no upper bound on wait time.

getNetworkStatus now aborts after the existing NODE_PROBE_TIMEOUT_MS (10s). getSnapMarketData gets a new SNAP_MARKET_TIMEOUT_MS (10s) on the Dexscreener request. Slow or hung upstreams should fail fast instead of holding Next.js workers open; existing catch paths still return error-shaped responses (including timeout messaging where errorMessage applies).

Reviewed by Cursor Bugbot for commit b366e61. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Stop hanging on slow external API calls

What Changed

  • Network status checks now stop after 10 seconds instead of waiting indefinitely for the upstream node
  • Snap market data requests now also fail after 10 seconds if Dexscreener does not respond
  • Slow or stuck upstream services now return an error sooner, reducing the chance of stalled background work

Impact

✅ Fewer stuck status checks
✅ Faster failure on slow third-party APIs
✅ Lower chance of worker exhaustion from hanging requests

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add timeouts to external API calls in getNetworkStatus and getSnapMarketData

  • Adds AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS) to the fetch call in network.ts; on timeout, getNetworkStatus returns ok: false with the error message.
  • Adds a SNAP_MARKET_TIMEOUT_MS constant (10,000ms) and applies it via AbortSignal.timeout to the Dexscreener fetch in snap-market.ts; on timeout, getSnapMarketData returns ok: false with the error message.
  • Behavioral Change: both functions previously had no timeout, so slow or hung external requests will now be aborted and return failure responses instead of hanging indefinitely.

Macroscope summarized b366e61.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 29, 2026 9:00pm

Request Review

@codeant-ai

codeant-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai

codeant-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 29, 2026
@codeant-ai

codeant-ai Bot commented Jun 29, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant