🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch calls - #33
Conversation
Added `signal: AbortSignal.timeout(TIMEOUT_MS)` to multiple `fetch` calls across the codebase to prevent hanging requests and server resource exhaustion. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
CodeAnt AI is reviewing your PR. |
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
CodeAnt AI finished reviewing your PR. |
User description
🚨 Severity: MEDIUM
💡 Vulnerability: The native
fetchAPI lacks a default timeout, which can cause requests to hang indefinitely if the remote server becomes unresponsive.🎯 Impact: Hanging requests can lead to server resource exhaustion, connection pool depletion, and potential Denial of Service (DoS).
🔧 Fix: Added
signal: AbortSignal.timeout(...)to externalfetchcalls insrc/lib/network.ts,src/lib/snap-market.ts, andscripts/sync-sources.mjswith appropriate timeout values.✅ Verification: Successfully ran
npm run lint,npm run typecheck, andnpm run buildto verify code correctness. All requests are properly enclosed intry/catchblocks to handle resultingTimeoutErrorexceptions.PR created automatically by Jules for task 14815752205669755317 started by @felirami
Note
Low Risk
Small, defensive change with bounded timeouts; no auth or data-model changes, and errors are already handled in callers.
Overview
Adds
AbortSignal.timeoutto outboundfetchcalls so hung upstream APIs cannot hold connections open indefinitely.scripts/sync-sources.mjsdefinesGITHUB_API_TIMEOUT_MS(30s) and applies it to bothfetchGithubJsonandfetchGithubText, covering all GitHub sync traffic.src/lib/network.tsadds the same pattern togetNetworkStatus(10s via existingNODE_PROBE_TIMEOUT_MS).src/lib/snap-market.tsexportsSNAP_MARKET_TIMEOUT_MS(10s) and uses it ingetSnapMarketDatafor Dexscreener.Failures surface through existing
try/catchpaths (including timeout-aware messaging innetwork.ts).Reviewed by Cursor Bugbot for commit 98f3e68. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Prevent external requests from hanging indefinitely
What Changed
Impact
✅ Fewer stuck network checks✅ Fewer stalled market data requests✅ Shorter GitHub sync runs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add 30s timeouts to GitHub API and market data fetch calls
AbortSignal.timeout()tofetchGithubJsonandfetchGithubTextin sync-sources.mjs with a 30s timeout via a newGITHUB_API_TIMEOUT_MSconstant.getNetworkStatusin network.ts using the existingNODE_PROBE_TIMEOUT_MSconstant, returningok: falseon abort.getSnapMarketDatain snap-market.ts via a new exportedSNAP_MARKET_TIMEOUT_MSconstant, returningok: falseon timeout.Macroscope summarized 98f3e68.