Skip to content

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch calls - #33

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-14815752205669755317
Open

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch calls#33
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-14815752205669755317

Conversation

@felirami

@felirami felirami commented Jun 27, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: The native fetch API lacks a default timeout, which can cause requests to hang indefinitely if the remote server becomes unresponsive.
🎯 Impact: Hanging requests can lead to server resource exhaustion, connection pool depletion, and potential Denial of Service (DoS).
🔧 Fix: Added signal: AbortSignal.timeout(...) to external fetch calls in src/lib/network.ts, src/lib/snap-market.ts, and scripts/sync-sources.mjs with appropriate timeout values.
✅ Verification: Successfully ran npm run lint, npm run typecheck, and npm run build to verify code correctness. All requests are properly enclosed in try/catch blocks to handle resulting TimeoutError exceptions.


PR created automatically by Jules for task 14815752205669755317 started by @felirami


Note

Low Risk
Small, defensive change with bounded timeouts; no auth or data-model changes, and errors are already handled in callers.

Overview
Adds AbortSignal.timeout to outbound fetch calls so hung upstream APIs cannot hold connections open indefinitely.

scripts/sync-sources.mjs defines GITHUB_API_TIMEOUT_MS (30s) and applies it to both fetchGithubJson and fetchGithubText, covering all GitHub sync traffic. src/lib/network.ts adds the same pattern to getNetworkStatus (10s via existing NODE_PROBE_TIMEOUT_MS). src/lib/snap-market.ts exports SNAP_MARKET_TIMEOUT_MS (10s) and uses it in getSnapMarketData for Dexscreener.

Failures surface through existing try/catch paths (including timeout-aware messaging in network.ts).

Reviewed by Cursor Bugbot for commit 98f3e68. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Prevent external requests from hanging indefinitely

What Changed

  • Network status checks now stop after a short timeout instead of waiting forever for an unresponsive service
  • Snap market data requests now fail fast when Dexscreener does not respond in time
  • GitHub sync requests now stop after 30 seconds, reducing the chance of stalled source updates

Impact

✅ Fewer stuck network checks
✅ Fewer stalled market data requests
✅ Shorter GitHub sync runs

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add 30s timeouts to GitHub API and market data fetch calls

  • Adds AbortSignal.timeout() to fetchGithubJson and fetchGithubText in sync-sources.mjs with a 30s timeout via a new GITHUB_API_TIMEOUT_MS constant.
  • Adds a timeout to getNetworkStatus in network.ts using the existing NODE_PROBE_TIMEOUT_MS constant, returning ok: false on abort.
  • Adds a 10s timeout to getSnapMarketData in snap-market.ts via a new exported SNAP_MARKET_TIMEOUT_MS constant, returning ok: false on timeout.
  • Behavioral Change: all three fetch sites now reject or return an error after their respective timeouts instead of hanging indefinitely.

Macroscope summarized 98f3e68.

Added `signal: AbortSignal.timeout(TIMEOUT_MS)` to multiple `fetch` calls across the codebase to prevent hanging requests and server resource exhaustion.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 27, 2026 8:52pm

Request Review

@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@codeant-ai

codeant-ai Bot commented Jun 27, 2026

Copy link
Copy Markdown

CodeAnt AI is reviewing your PR.

@codeant-ai

codeant-ai Bot commented Jun 27, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 27, 2026
@codeant-ai

codeant-ai Bot commented Jun 27, 2026

Copy link
Copy Markdown

CodeAnt AI finished reviewing your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant