🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests - #28
🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests#28felirami wants to merge 1 commit into
Conversation
Native `fetch` API does not provide a default timeout. If the remote server is unresponsive, the connection remains open indefinitely. This commit adds a timeout configuration for external fetch calls using `signal: AbortSignal.timeout(TIMEOUT_MS)` to ensure fail-fast behavior and prevent potential Denial of Service (DoS) due to hanging requests and resource exhaustion. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using high effort and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit f222a60. Configure here.
| "X-GitHub-Api-Version": "2022-11-28", | ||
| ...(githubToken ? { Authorization: `Bearer ${githubToken}` } : {}), | ||
| }, | ||
| signal: AbortSignal.timeout(GITHUB_API_TIMEOUT_MS), |
There was a problem hiding this comment.
Optional GitHub fetch throws on timeout
Medium Severity
Adding AbortSignal.timeout to fetchGithubJson and fetchGithubText lets timed-out requests throw before the HTTP status checks. Call sites that pass optional: true only treat 404/409 as skippable, so a slow or stuck optional GitHub resource aborts the whole sync:sources run instead of returning null or "" like a missing file.
Reviewed by Cursor Bugbot for commit f222a60. Configure here.


User description
🚨 Severity: MEDIUM
💡 Vulnerability: The native
fetchAPI lacks a default timeout. Requests to external endpoints might hang indefinitely if the remote server is unresponsive, potentially leading to server-side resource exhaustion and a Denial of Service (DoS) risk.🎯 Impact: If external APIs like GitHub, Dexscreener, or public nodes are slow or hang, the application could consume unbounded resources, eventually blocking subsequent legitimate requests.
🔧 Fix: Added explicit timeouts to external
fetchcalls inscripts/sync-sources.mjs,src/lib/network.ts, andsrc/lib/snap-market.tsusingAbortSignal.timeout().✅ Verification: Run
npm run typecheckandnpm run buildto verify the codebase compiles correctly without any issues. The application should now fail fast instead of hanging on external network requests.PR created automatically by Jules for task 17301272163866889054 started by @felirami
Note
Low Risk
Small, defensive networking changes with existing try/catch error paths; no auth or data-model changes.
Overview
Adds fail-fast timeouts on server-side
fetchcalls that previously could hang indefinitely when upstream APIs stall.scripts/sync-sources.mjsintroduces a 30s GitHub API timeout on both JSON and raw text helpers.getNetworkStatusinsrc/lib/network.tsnow uses the existing 10s node probe timeout (matching other health checks).getSnapMarketDatainsrc/lib/snap-market.tsadds a 10s Dexscreener timeout.Documents the pattern in
.jules/sentinel.mdfor future reviews.Reviewed by Cursor Bugbot for commit f222a60. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Add timeouts to external requests so slow upstream services do not hang the app
What Changed
Impact
✅ Fewer stuck data refreshes✅ Lower risk of request pileups✅ Clearer failure behavior when upstream services are slow💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add 30s/10s
AbortSignaltimeouts to external fetch requestssignal: AbortSignal.timeout(GITHUB_API_TIMEOUT_MS)(30s) tofetchGithubJsonandfetchGithubTextin sync-sources.mjssignal: AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)to the fetch ingetNetworkStatusin network.tssignal: AbortSignal.timeout(SNAP_MARKET_TIMEOUT_MS)(10s) to the fetch ingetSnapMarketDatain snap-market.ts{ ok: false, error: ... }on timeout instead of hanging indefinitelyMacroscope summarized f222a60.