π‘οΈ Sentinel: [MEDIUM] Add timeouts to external API calls - #26
π‘οΈ Sentinel: [MEDIUM] Add timeouts to external API calls#26felirami wants to merge 1 commit into
Conversation
This commit adds `signal: AbortSignal.timeout(...)` to native `fetch` calls across the codebase, specifically in: - `src/lib/network.ts` (network probe checks) - `src/lib/snap-market.ts` (Dexscreener API data fetches) - `scripts/sync-sources.mjs` (GitHub API data fetches) The native `fetch` API does not enforce a default timeout. Unresponsive endpoints can cause hanging connections, leading to server resource exhaustion (Denial of Service) and permanently stuck build scripts. Adding explicit abort signals ensures these requests fail quickly and securely when upstream services are unresponsive. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! πWe're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X Β· |
User description
π¨ Severity: MEDIUM
π‘ Vulnerability: Missing fetch timeouts on external API calls
π― Impact: Unresponsive third-party APIs (like GitHub or Dexscreener) could cause hanging network connections. This leads to server resource exhaustion (Denial of Service risk) on Vercel or locally, and causes build scripts (
sync-sources.mjs) to hang indefinitely.π§ Fix: Added explicit
AbortSignal.timeout(...)flags (typically 10 seconds) to nativefetchcalls insrc/lib/network.ts,src/lib/snap-market.ts, andscripts/sync-sources.mjs.β Verification: Ran
npm run lint,npm run typecheck, andnpm run buildto verify the codebase compiles successfully with the changes.PR created automatically by Jules for task 598450121395458861 started by @felirami
Note
Low Risk
Small, defensive networking change with existing error handling; may surface more timeout failures under slow third-party APIs but avoids hung requests.
Overview
Adds
AbortSignal.timeout(10 seconds) to outboundfetchcalls that previously could hang indefinitely when GitHub, the public node info endpoint, or Dexscreener were slow or unresponsive.scripts/sync-sources.mjsapplies the timeout infetchGithubJsonandfetchGithubText, so the source-sync build step fails fast instead of stalling.getNetworkStatusinsrc/lib/network.tsuses the existingNODE_PROBE_TIMEOUT_MSconstant for the public node probe.getSnapMarketDatainsrc/lib/snap-market.tsintroducesFETCH_TIMEOUT_MSand passes it on the Dexscreener request; existingcatchpaths continue to surface errors (including timeouts) to callers.Reviewed by Cursor Bugbot for commit cb00e8f. Bugbot is set up for automated code reviews on this repo. Configure here.
CodeAnt-AI Description
Add timeouts to external API requests
What Changed
Impact
β Fewer stuck build jobsβ Lower risk of hanging network requestsβ Clearer failures when third-party APIs are slowπ‘ Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.