Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Add timeouts to external API calls - #26

Open
felirami wants to merge 1 commit into
mainfrom
sentinel/fetch-timeouts-598450121395458861
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Add timeouts to external API calls#26
felirami wants to merge 1 commit into
mainfrom
sentinel/fetch-timeouts-598450121395458861

Conversation

@felirami

@felirami felirami commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Missing fetch timeouts on external API calls
🎯 Impact: Unresponsive third-party APIs (like GitHub or Dexscreener) could cause hanging network connections. This leads to server resource exhaustion (Denial of Service risk) on Vercel or locally, and causes build scripts (sync-sources.mjs) to hang indefinitely.
πŸ”§ Fix: Added explicit AbortSignal.timeout(...) flags (typically 10 seconds) to native fetch calls in src/lib/network.ts, src/lib/snap-market.ts, and scripts/sync-sources.mjs.
βœ… Verification: Ran npm run lint, npm run typecheck, and npm run build to verify the codebase compiles successfully with the changes.


PR created automatically by Jules for task 598450121395458861 started by @felirami


Note

Low Risk
Small, defensive networking change with existing error handling; may surface more timeout failures under slow third-party APIs but avoids hung requests.

Overview
Adds AbortSignal.timeout (10 seconds) to outbound fetch calls that previously could hang indefinitely when GitHub, the public node info endpoint, or Dexscreener were slow or unresponsive.

scripts/sync-sources.mjs applies the timeout in fetchGithubJson and fetchGithubText, so the source-sync build step fails fast instead of stalling. getNetworkStatus in src/lib/network.ts uses the existing NODE_PROBE_TIMEOUT_MS constant for the public node probe. getSnapMarketData in src/lib/snap-market.ts introduces FETCH_TIMEOUT_MS and passes it on the Dexscreener request; existing catch paths continue to surface errors (including timeouts) to callers.

Reviewed by Cursor Bugbot for commit cb00e8f. Bugbot is set up for automated code reviews on this repo. Configure here.


CodeAnt-AI Description

Add timeouts to external API requests

What Changed

  • Requests to GitHub, Dexscreener, and the public node status endpoint now stop after a short timeout instead of hanging indefinitely.
  • Source-sync jobs fail fast when GitHub is slow or unresponsive, so builds do not stall on external network calls.
  • Market and network status checks now return sooner when upstream services do not respond.

Impact

βœ… Fewer stuck build jobs
βœ… Lower risk of hanging network requests
βœ… Clearer failures when third-party APIs are slow

πŸ’‘ Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

This commit adds `signal: AbortSignal.timeout(...)` to native `fetch` calls across the codebase, specifically in:
- `src/lib/network.ts` (network probe checks)
- `src/lib/snap-market.ts` (Dexscreener API data fetches)
- `scripts/sync-sources.mjs` (GitHub API data fetches)

The native `fetch` API does not enforce a default timeout. Unresponsive endpoints can cause hanging connections, leading to server resource exhaustion (Denial of Service) and permanently stuck build scripts.

Adding explicit abort signals ensures these requests fail quickly and securely when upstream services are unresponsive.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 20, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 20, 2026 8:56pm

Request Review

@codeant-ai

codeant-ai Bot commented Jun 20, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! πŸŽ‰

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X Β·
Reddit Β·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant