🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch calls - #23
Conversation
The native JavaScript fetch API does not have a default timeout. If an external service hangs, fetch requests can wait indefinitely, which may lead to server resource exhaustion and potential Denial of Service (DoS). This commit adds explicit timeouts using `signal: AbortSignal.timeout()` to all external fetch calls in: - `src/lib/network.ts` (`NODE_PROBE_TIMEOUT_MS`) - `src/lib/snap-market.ts` (`SNAP_MARKET_TIMEOUT_MS`) - `scripts/sync-sources.mjs` (`FETCH_TIMEOUT_MS`) It also updates the Sentinel journal to document this vulnerability and prevention strategy. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
User description
🚨 Severity: MEDIUM
💡 Vulnerability: The native Javascript
fetchAPI does not have a default timeout. When querying external services (such as GitHub APIs, Dexscreener, or public Farcaster nodes), if the service hangs or stops responding, thefetchrequest will wait indefinitely.🎯 Impact: In a high-traffic environment, hanging requests can lead to server resource exhaustion (e.g., hanging worker threads or Vercel serverless function timeouts), potentially causing a Denial of Service (DoS) for the application. It can also cause build scripts like
sync-sources.mjsto hang indefinitely in CI/CD pipelines.🔧 Fix: Added explicit timeouts to all external
fetchcalls usingsignal: AbortSignal.timeout(TIMEOUT_MS).src/lib/network.ts: Re-used existingNODE_PROBE_TIMEOUT_MSforgetNetworkStatus.src/lib/snap-market.ts: IntroducedSNAP_MARKET_TIMEOUT_MS(10s) for Dexscreener API queries.scripts/sync-sources.mjs: IntroducedFETCH_TIMEOUT_MS(30s) for GitHub API queries..jules/sentinel.mdto ensure future external fetch calls include timeouts.✅ Verification:
npm run lintandnpm run typecheck(Pass).npm run build(Successfully compiled).fetchcalls are missing anAbortSignal.PR created automatically by Jules for task 9745223678269127453 started by @felirami
CodeAnt-AI Description
Prevent external requests from hanging indefinitely
What Changed
Impact
✅ Fewer stuck server requests✅ Lower risk of build jobs hanging✅ Fewer service outages from unresponsive APIs💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add 30s/10s
AbortSignaltimeouts to external fetch callsAbortSignal.timeout(FETCH_TIMEOUT_MS)(30s) tofetchGithubJsonandfetchGithubTextin sync-sources.mjsAbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)togetNetworkStatusin network.tsAbortSignal.timeout(SNAP_MARKET_TIMEOUT_MS)(10s) togetSnapMarketDatain snap-market.tsMacroscope summarized 714ada5.