Skip to content

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests - #22

Open
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-4467866573175239823
Open

🛡️ Sentinel: [MEDIUM] Add timeouts to external fetch requests#22
felirami wants to merge 1 commit into
mainfrom
sentinel-fetch-timeouts-4467866573175239823

Conversation

@felirami

@felirami felirami commented Jun 16, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
💡 Vulnerability: External fetch requests without explicit timeouts can hang indefinitely if the remote server fails to respond, leading to resource exhaustion, memory leaks, and potential Denial of Service (DoS) conditions.
🎯 Impact: Prevents server resource exhaustion or blocked executions resulting from unresponsive third-party APIs (e.g. GitHub API, DexScreener API, external Farcaster Node endpoints).
🔧 Fix: Added signal: AbortSignal.timeout(...) to all native fetch calls. Added constants for timeout durations where appropriate (MARKET_FETCH_TIMEOUT_MS = 10_000, and reusing existing NODE_PROBE_TIMEOUT_MS or 10000).
Verification: Verified by successfully running npm run lint, npm run typecheck, and npm run build locally without introducing regressions. The code changes are purely defensive.


PR created automatically by Jules for task 4467866573175239823 started by @felirami


CodeAnt-AI Description

Add timeouts to external requests so slow services do not hang the app

What Changed

  • External requests now fail after a fixed time instead of waiting indefinitely
  • Network checks, market data fetches, and GitHub sync requests are covered
  • This reduces the chance of stalled jobs and blocked server work when third-party services are slow or unresponsive

Impact

✅ Fewer hanging API requests
✅ Lower risk of blocked background syncs
✅ Fewer resource exhaustion incidents

💡 Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Add `AbortSignal.timeout` to external `fetch` calls across the codebase (GitHub sync, Dexscreener market data, and Farcaster node info) to prevent hanging requests and mitigate resource exhaustion risks.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 16, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 16, 2026 9:00pm

Request Review

@codeant-ai

codeant-ai Bot commented Jun 16, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! 🎉

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X ·
Reddit ·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant