π‘οΈ Sentinel: [MEDIUM] Add explicit timeouts to external API fetch calls - #21
π‘οΈ Sentinel: [MEDIUM] Add explicit timeouts to external API fetch calls#21felirami wants to merge 1 commit into
Conversation
Severity: MEDIUM Vulnerability: Missing timeouts on external `fetch` calls. Impact: The native `fetch` API lacks a default timeout. If the remote server hangs or is unresponsive, the connection remains open indefinitely, leading to server resource exhaustion and potential Denial of Service (DoS). Fix: Added explicit timeouts using `AbortSignal.timeout()` to `fetch` calls in `src/lib/network.ts` and `src/lib/snap-market.ts`. Verification: Ran `npm run lint`, `npm run typecheck`, and `npm run build` locally. Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Thanks for using CodeAnt! πWe're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X Β· |
User description
π¨ Severity: MEDIUM
π‘ Vulnerability: Missing timeouts on external
fetchcalls.π― Impact: The native
fetchAPI lacks a default timeout. If the remote server hangs or is unresponsive, the connection remains open indefinitely, leading to server resource exhaustion and potential Denial of Service (DoS) for the Next.js API routes.π§ Fix: Added explicit timeouts using
AbortSignal.timeout()tofetchcalls insrc/lib/network.tsandsrc/lib/snap-market.ts(NODE_PROBE_TIMEOUT_MSandMARKET_DATA_TIMEOUT_MS).β Verification: Verified by running
npm run lint,npm run typecheck, andnpm run buildlocally, all of which pass without errors.PR created automatically by Jules for task 7622011122332107204 started by @felirami
CodeAnt-AI Description
Add timeouts to external API checks
What Changed
Impact
β Fewer hung status checksβ Lower risk of stalled market data refreshesβ Reduced server resource exhaustionπ‘ Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.
Note
Add explicit timeouts to external API fetch calls in network and market data modules
AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS)to thegetNetworkStatusfetch in network.ts so node info probes are bounded by the existing timeout constant.MARKET_DATA_TIMEOUT_MSconstant (10,000 ms) and applies it viaAbortSignal.timeoutto the Dexscreener fetch ingetSnapMarketDatain snap-market.ts.ok=falsewith an error message rather than hanging indefinitely.Macroscope summarized 729834f.