Skip to content

πŸ›‘οΈ Sentinel: [MEDIUM] Add explicit timeouts to external API fetch calls - #21

Open
felirami wants to merge 1 commit into
mainfrom
sentinel/add-fetch-timeouts-7622011122332107204
Open

πŸ›‘οΈ Sentinel: [MEDIUM] Add explicit timeouts to external API fetch calls#21
felirami wants to merge 1 commit into
mainfrom
sentinel/add-fetch-timeouts-7622011122332107204

Conversation

@felirami

@felirami felirami commented Jun 15, 2026

Copy link
Copy Markdown
Collaborator

User description

🚨 Severity: MEDIUM
πŸ’‘ Vulnerability: Missing timeouts on external fetch calls.
🎯 Impact: The native fetch API lacks a default timeout. If the remote server hangs or is unresponsive, the connection remains open indefinitely, leading to server resource exhaustion and potential Denial of Service (DoS) for the Next.js API routes.
πŸ”§ Fix: Added explicit timeouts using AbortSignal.timeout() to fetch calls in src/lib/network.ts and src/lib/snap-market.ts (NODE_PROBE_TIMEOUT_MS and MARKET_DATA_TIMEOUT_MS).
βœ… Verification: Verified by running npm run lint, npm run typecheck, and npm run build locally, all of which pass without errors.


PR created automatically by Jules for task 7622011122332107204 started by @felirami


CodeAnt-AI Description

Add timeouts to external API checks

What Changed

  • Network status checks now stop after a fixed time instead of waiting indefinitely for an unresponsive server
  • Snap market data requests now also stop after a fixed time, reducing the chance of stalled data updates

Impact

βœ… Fewer hung status checks
βœ… Lower risk of stalled market data refreshes
βœ… Reduced server resource exhaustion

πŸ’‘ Usage Guide

Checking Your Pull Request

Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.

Talking to CodeAnt AI

Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:

@codeant-ai ask: Your question here

This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.

Example

@codeant-ai ask: Can you suggest a safer alternative to storing this secret?

Preserve Org Learnings with CodeAnt

You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:

@codeant-ai: Your feedback here

This helps CodeAnt AI learn and adapt to your team's coding style and standards.

Example

@codeant-ai: Do not flag unused imports.

Retrigger review

Ask CodeAnt AI to review the PR again, by typing:

@codeant-ai: review

Check Your Repository Health

To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.

Note

Add explicit timeouts to external API fetch calls in network and market data modules

  • Adds AbortSignal.timeout(NODE_PROBE_TIMEOUT_MS) to the getNetworkStatus fetch in network.ts so node info probes are bounded by the existing timeout constant.
  • Introduces a new MARKET_DATA_TIMEOUT_MS constant (10,000 ms) and applies it via AbortSignal.timeout to the Dexscreener fetch in getSnapMarketData in snap-market.ts.
  • Behavioral Change: timed-out requests in both functions now return ok=false with an error message rather than hanging indefinitely.

Macroscope summarized 729834f.

Severity: MEDIUM
Vulnerability: Missing timeouts on external `fetch` calls.
Impact: The native `fetch` API lacks a default timeout. If the remote server hangs or is unresponsive, the connection remains open indefinitely, leading to server resource exhaustion and potential Denial of Service (DoS).
Fix: Added explicit timeouts using `AbortSignal.timeout()` to `fetch` calls in `src/lib/network.ts` and `src/lib/snap-market.ts`.
Verification: Ran `npm run lint`, `npm run typecheck`, and `npm run build` locally.

Co-authored-by: felirami <6752178+felirami@users.noreply.github.com>
@google-labs-jules

Copy link
Copy Markdown
Contributor

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@vercel

vercel Bot commented Jun 15, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hypersnaporg Ready Ready Preview, Comment Jun 15, 2026 8:46pm

Request Review

@codeant-ai

codeant-ai Bot commented Jun 15, 2026

Copy link
Copy Markdown

Thanks for using CodeAnt! πŸŽ‰

We're free for open-source projects. if you're enjoying it, help us grow by sharing.

Share on X Β·
Reddit Β·
LinkedIn

@codeant-ai codeant-ai Bot added the size:XS This PR changes 0-9 lines, ignoring generated files label Jun 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS This PR changes 0-9 lines, ignoring generated files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant