fix: prevent stack overflow on deeply nested JSON payloads - #111
Merged
Conversation
Replace recursive scan_value with an iterative explicit-stack traversal capped at MAX_DEPTH=64. Refactor redact_value to depth-parameterised recursion that returns the value unchanged beyond REDACT_MAX_DEPTH=64 instead of panicking. Add two boundary unit tests. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
scan_valueinpayload_filter.rswas fully recursive and would overflow the stack on pathologically nested JSON arguments. Replaced with an explicit-stack iterative traversal capped atMAX_DEPTH = 64.redact_valueingateway.rswas also recursive; refactored to depth-parameterised recursion (redact_value_depth) that returns the value unchanged beyondREDACT_MAX_DEPTH = 64instead of panicking.Closes #95
Test plan
cargo test --lib— all 431 unit tests passcargo clippy -- -D warnings— zero warningscargo fmt --check— no formatting violationsdeeply_nested_json_blocked— nesting beyond MAX_DEPTH triggers blockmax_depth_exactly_allowed— nesting at exactly MAX_DEPTH passes through🤖 Generated with Claude Code