fix(ext): _ShimAnalyzerResolver.libraries should yield cross-package#2
Open
pcj wants to merge 1 commit into
Open
fix(ext): _ShimAnalyzerResolver.libraries should yield cross-package#2pcj wants to merge 1 commit into
pcj wants to merge 1 commit into
Conversation
Resolver.libraries previously yielded only same-package staged files (the input + each --dep). Cross-package public re-export libraries - e.g. package:stacked_services/stacked_services.dart - were never yielded, even though they're reachable through the analyzer's session and import directly from the input under analysis. build_runner's Resolver yields every library the analysis session has loaded. Generators that walk Resolver.libraries to look up a type's public re-exporting library (notably stacked_generator's ImportResolver) silently fail under the narrower set, computing wrong import paths or returning null for elements that ARE reachable. Yield each package's conventional package:<name>/<name>.dart library from the synthesized PackageConfig in addition to the same-package staged entries. The lazy analyzer load keeps the cost negligible - libraryFor only materializes packages the consumer iterates over. Adds four tests covering: baseline same-package yield, cross-package yield (using an on-disk fake foreign package), no-double-yield dedup, and tolerance of packages with non-conventional layouts.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolver.libraries previously yielded only same-package staged files (the input + each --dep). Cross-package public re-export libraries - e.g. package:stacked_services/stacked_services.dart - were never yielded, even though they're reachable through the analyzer's session and import directly from the input under analysis.
build_runner's Resolver yields every library the analysis session has loaded. Generators that walk Resolver.libraries to look up a type's public re-exporting library (notably stacked_generator's ImportResolver) silently fail under the narrower set, computing wrong import paths or returning null for elements that ARE reachable.
Yield each package's conventional package:/.dart library from the synthesized PackageConfig in addition to the same-package staged entries. The lazy analyzer load keeps the cost negligible - libraryFor only materializes packages the consumer iterates over.
Adds four tests covering: baseline same-package yield, cross-package yield (using an on-disk fake foreign package), no-double-yield dedup, and tolerance of packages with non-conventional layouts.