fix: playwright driver の CDN 404 で定期実行が失敗する問題を解消 - #107
Merged
Conversation
Co-Authored-By: ara-ta3 <2089153+ara-ta3@users.noreply.github.com>
Contributor
Author
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
定期実行 (
scheduled-crawler.yml→make run) がplaywright install failedで失敗していた原因を修正。原因は Microsoft が旧 driver 配布用 CDN (
playwright.azureedge.netなど) を廃止したこと。playwright-goはこの CDN から driver zip を DL していたため 404 になっていた:これは
playwright-gov0.6100.0 (PR mxschmitt/playwright-go#615) で修正済み。以降は npm (playwright-core) +nodejs.org/distから driver を組み立てる方式に変わり、廃止 CDN に依存しなくなった。なお v0.6100.0 はモジュールパスが
github.com/playwright-community/playwright-goからgithub.com/mxschmitt/playwright-goに戻っているため、import パスも合わせて変更している(パッケージ名playwrightは不変なのでコード本体の変更は不要)。go.mod:playwright-community/playwright-go v0.6000.0→mxschmitt/playwright-go v0.6100.0pkg/domains/nihontsushin.go: import パスをmxschmitt/playwright-goに変更検証
make build/make testOKplaywright.Install(SkipInstallBrowsers: true)を単体実行し、driver DL が成功することを確認 (INSTALL OK)Link to Devin session: https://app.devin.ai/sessions/7f595434415b47c4afbaf8a659015cc5