[ABC Wallet] Support ABC Wallet#396
Open
bryan-ahnlab wants to merge 18 commits into
Open
Conversation
bryan-ahnlab
requested review from
0xmaayan,
hardsetting,
kaw2k and
kent-white
as code owners
August 12, 2024 06:16
bryan-ahnlab
changed the title
0xmaayan
requested changes
Aug 12, 2024
0xmaayan
left a comment
0xmaayan
left a comment
Contributor
There was a problem hiding this comment.
Please run pnpm run changeset to include these changes in the next release
https://github.com/aptos-labs/aptos-wallet-adapter/blob/main/CONTRIBUTING.md#changesets
0xmaayan
reviewed
Aug 15, 2024
kent-white
approved these changes
Aug 22, 2024
kent-white
enabled auto-merge (squash)
August 22, 2024 17:51
kent-white
self-requested a review
August 22, 2024 21:35
Contributor
|
We are worried about this wallet showing up on desktop, when its not available on desktop. We may need to introduce another commit that hides non-desktop wallets from desktop surfaces |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request contains the support of ABC Wallet.