Skip to content

Bump aiohttp from 3.13.5 to 3.14.1 in /v2 - #114

Merged
gregnazario merged 2 commits into
mainfrom
dependabot/uv/v2/aiohttp-3.14.1
Jun 18, 2026
Merged

Bump aiohttp from 3.13.5 to 3.14.1 in /v2#114
gregnazario merged 2 commits into
mainfrom
dependabot/uv/v2/aiohttp-3.14.1

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jun 17, 2026

Copy link
Copy Markdown
Contributor

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code labels Jun 17, 2026
@dependabot
dependabot Bot requested review from a team and gregnazario as code owners June 17, 2026 10:37
---
updated-dependencies:
- dependency-name: aiohttp
  dependency-version: 3.14.1
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/uv/v2/aiohttp-3.14.1 branch from 5fd0967 to a37045d Compare June 18, 2026 10:34
@gregnazario

Copy link
Copy Markdown
Contributor

@cursoragent look into why this PR keeps failing in CI

@cursor

cursor Bot commented Jun 18, 2026

Copy link
Copy Markdown

Root cause

The V2 standalone tests were failing because aiohttp 3.14 added a required stream_writer keyword argument to ClientResponse.__init__(). The test mock library aioresponses 0.7.8 constructs ClientResponse directly and does not pass that argument, so 60 unit tests failed with:

TypeError: ClientResponse.__init__() missing 1 required keyword-only argument: 'stream_writer'

This is not a bug in the SDK itself — it's a test-only incompatibility between aioresponses and aiohttp 3.14.

Fix applied

I pushed commit b15f06e to dependabot/uv/v2/aiohttp-3.14.1 with:

  1. v2/tests/conftest.py — a session-scoped pytest shim that patches aioresponses to supply a minimal stream_writer when running against aiohttp 3.14+ (same pattern used by other projects handling this upgrade).
  2. v2/pyproject.toml — bumped the aioresponses dev dependency floor from >=0.7 to >=0.7.8.

All 417 v2 unit tests pass locally with aiohttp 3.14.1.

CI should pass on the next run. Note: Dependabot may overwrite manual edits if someone triggers @dependabot rebase — the conftest shim should be kept alongside the aiohttp bump.

Open in Web Open in Cursor 

aiohttp 3.14 requires a stream_writer argument when constructing
ClientResponse. aioresponses 0.7.8 does not provide it, causing 60 unit
tests to fail in CI.

Add a session-scoped pytest shim that supplies a minimal stream_writer
when running against aiohttp 3.14+, and bump the aioresponses dev
dependency floor to >=0.7.8.

Co-authored-by: Greg Nazario <greg@gnazar.io>
@codecov

codecov Bot commented Jun 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 93.20%. Comparing base (2dcd0ed) to head (b15f06e).
⚠️ Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #114      +/-   ##
==========================================
+ Coverage   93.19%   93.20%   +0.01%     
==========================================
  Files          56       56              
  Lines        5172     5183      +11     
==========================================
+ Hits         4820     4831      +11     
  Misses        352      352              
Flag Coverage Δ
v1-sdk 90.36% <ø> (+0.01%) ⬆️
v2-sdk 97.02% <ø> (+<0.01%) ⬆️
see 2 files with indirect coverage changes
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gregnazario
gregnazario enabled auto-merge June 18, 2026 10:40
@gregnazario
gregnazario disabled auto-merge June 18, 2026 10:44
@gregnazario
gregnazario merged commit 5ee34ce into main Jun 18, 2026
13 checks passed
@gregnazario
gregnazario deleted the dependabot/uv/v2/aiohttp-3.14.1 branch June 18, 2026 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file python:uv Pull requests that update python:uv code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants