Bugfix: serialize runs in a background thread - #539
Merged
Conversation
Collaborator
|
I've reviewed this PR now, please see: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is endpoint is only called by the
apsis runsCLI command. It blocks the event loop for 60s in our environment if called without filters.Note that I'm going to have to do something about a potential full run store query in the same method, once that is slower from serving the run store from sqlite instead of memory #538.
apsis/python/apsis/service/api.py
Lines 484 to 490 in 64be4c4