Inject a resource provider to decouple network access - #201
Merged
Conversation
apriha
force-pushed
the
v3/resource-provider
branch
from
July 2, 2026 04:08
7735cb2 to
41d89b4
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #201 +/- ##
==========================================
- Coverage 92.78% 88.54% -4.24%
==========================================
Files 12 12
Lines 2147 2138 -9
Branches 344 344
==========================================
- Hits 1992 1893 -99
- Misses 89 181 +92
+ Partials 66 64 -2 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Move all resource downloading and caching behind a ResourceProvider so operations run with zero network and zero mocks. Replace the hand-rolled urllib downloader with pooch, cache resources in an OS-specific directory (overridable via SNPS_DATA_DIR), and drop the Singleton on Resources in favor of explicit injection into SNPs. The suite now runs fully offline against a fixture-backed provider; the real resource servers are exercised only by a dedicated weekly CI job. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
apriha
force-pushed
the
v3/resource-provider
branch
from
July 2, 2026 04:19
41d89b4 to
2a74ee0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decouples the network/resource layer from the core so every operation runs with
zero network and zero mocks. Resources are now obtained through an injected
ResourceProvider(default: apooch-backedResources), theSingletonisgone, and the suite runs fully offline against a fixture-backed provider — the
real servers are contacted only by a weekly
live-integrationjob.Note: resources now cache to an OS-specific directory (override with
SNPS_DATA_DIR) instead of./resources, so existing caches re-download once.Adds
poochas a dependency.🤖 Generated with Claude Code