fix linting errors#130
Open
daria-sukhareva wants to merge 7 commits into
Open
Conversation
bunch of whitespaces
fix: SQLFluff lint compliance across all models - lowercase all SQL keywords (as, join, null, etc.) - add explicit AS for all table aliases; fix bare join → inner join - remove trailing commas from last SELECT column before FROM - exclude CV03 (trailing comma), LT02 (indent), and 7 other rules that conflict with dbt/Jinja patterns - rename fact_downtime_daily.type → reason to avoid reserved keyword - fix syntax errors in window functions and CASE expressions introduced by prior automated fix pass
cast string -> dbt.type_string() for cross-adapter compatibility
- Redundant else null removed from the two case expressions - relation_exists for short
- remove redundant SELECT DISTINCT alongside GROUP BY in dim_ports
- removed else null
more of the same
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: SQLFluff lint compliance across all models
that conflict with dbt/Jinja patterns
introduced by prior automated fix pass
Also cast to string replaced with cast to dbt.type_string() for cross-adapter compatibility @SYegor