Skip to content

test: add (failing) test for 2d fluids - #631

Merged
Ughuuu merged 1 commit into
appsinacup:mainfrom
benthillerkus:fluid2d-test
Sep 8, 2026
Merged

test: add (failing) test for 2d fluids#631
Ughuuu merged 1 commit into
appsinacup:mainfrom
benthillerkus:fluid2d-test

Conversation

@benthillerkus

@benthillerkus benthillerkus commented Sep 7, 2026

Copy link
Copy Markdown
Contributor

It seems fluid collisions broke recently and the test suite couldn't catch it

@Ughuuu

Ughuuu commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

odd, the tests seem to crash with godot crashing on cicd..

/home/runner/work/_temp/7b7826ce-9114-4f99-bd78-b5c4dd0c91a6.sh: line 3: 5035 Aborted (core dumped) "$GODOT4" --headless --path ./bin2d --import 2>&1

I wonder if it was like this for a while or if its new, will investigate anyway. Thx for contribution. This test you changed, I need to also check visually, so will do that and then merge if good.

@Ughuuu

Ughuuu commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Actually, on mac the tests pass, minus the 1 regression. Are you sure you added the test to the test suite?


    1 Regression(s):
        1. Faucet2D | testing collision > Fluid particles stay above the collision height

    6 Improvement(s):
        1. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in x with CCD Ray does not pass through the wall
        2. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in x with CCD Cast shape does not pass through the wall
        3. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in y with CCD Cast shape does not pass through the wall
        4. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in x with CCD Ray does not pass through the wall
        5. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in x with CCD Cast shape does not pass through the wall
        6. RigidBody2D | testing Continuous Collision Detection (CCD) > Rigid moving in y with CCD Cast shape does not pass through the wall

@benthillerkus

Copy link
Copy Markdown
Contributor Author

The issue with fluid physics I'm running into on the current version is that collisions seem to be ignored, so that's the regression test I've added.
I haven't had any issues with crashing (though I only tested on Windows).

@Ughuuu
Ughuuu merged commit faa72e1 into appsinacup:main Sep 8, 2026
68 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants