Fix HMS Push Notifications - #645
Merged
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #645 +/- ##
==========================================
+ Coverage 68.55% 68.66% +0.11%
==========================================
Files 21 21
Lines 1784 1781 -3
==========================================
Hits 1223 1223
+ Misses 501 498 -3
Partials 60 60
Continue to review full report at Codecov.
|
appleboy
approved these changes
Dec 9, 2021
This was referenced Dec 9, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses issue #644.
Since github.com/msalihkarakasli/go-hms-push doesn't receive any update in 7 months, I forked the lib and added a go module replace to my version that sends
foreground_showvariable. Also created a PR to the original lib here@appleboy probably we should release a GoRush 1.14.1 with these fixes?