Support attaching application-layer stream protocols to existing flows - #61
Merged
Conversation
mishtak00
requested review from
agnosticdev,
ekinnear and
tfpauly
as code owners
July 29, 2026 18:20
tfpauly
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added a general primitive for attaching an upper stream protocol onto an already-existing flow, for cases where a listener's stack has as application-layer protocol that must be added on top of inbound streams.
All changes:
attachLowerStreamProtocolToExistingFlow(listener:flowReference:)as anInboundStreamHandlerrequirement, with witnesses on the OneToOne and Top stream extensions,EINVALonStreamEndpointFlowProtocol(its lower is wired at construction), andENOTSUPonStreamPerfTestHandler. Reference dispatch covers.tls,.streamEndpointFlow,.customdeliverEnqueuedInboundStreamData(flowReference:)to replay data buffered before the upper protocol attachednewProtocolInstance(context:)on protocol options (nil onAbstractProtocolOptions, overridden inProtocolOptions<P>) so a custom application protocol can be materialized per flow without naming a concrete type