Make LinuxPod.stopContainer return ExitStatus explicitly#762
Open
noah-thor wants to merge 1 commit into
Open
Conversation
Update LinuxPod.stopContainer API to return the ExitStatus explicitly when the function call performs the kill and reaping itself. This lets callers observe the correct exit code without having to rely on other mechanisms.
dcantah
reviewed
Jun 2, 2026
|
|
||
| /// Stop a container from executing. | ||
| public func stopContainer(_ containerID: String) async throws { | ||
| /// |
Member
There was a problem hiding this comment.
Sorry I know we talked about this, but does this offer anything that just calling waitContainer right after stopContainer returns not give? If anything I'd love if we had some functionality to cache the exit code so we don't actually need to do an RPC, and then waitContainer (and wait on LinuxProcess which it just trampolines to) just returns a cached integer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update
LinuxPod.stopContainerAPI to return theExitStatusexplicitly when the function call performs the kill and reaping itself. This lets callers observe the correct exit code without having to rely on other mechanisms.