[APPHUD-890] Add setScreenPresentationStyle for iOS Rules screens - #95
Open
vlr-code wants to merge 1 commit into
Open
[APPHUD-890] Add setScreenPresentationStyle for iOS Rules screens#95vlr-code wants to merge 1 commit into
vlr-code wants to merge 1 commit into
Conversation
Adds ApphudSdk.setScreenPresentationStyle(ApphudScreenPresentationStyle) to control how Rules screens (including Figma rule paywalls) are presented on iOS: fullScreen or pageSheet. The native ApphudUIDelegate.apphudScreenPresentationStyle delegate method returns synchronously and cannot be bridged to async JS, so the chosen style is stored in the events module (same pattern as setApphudProductIdentifiers) and returned by the existing UI delegate proxy. While no style is set, the proxy hides the optional selector via responds(to:), keeping the SDK default behavior byte-for-byte. On Android the method is a safe no-op (the concept is iOS-only).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
ApphudSdk.setScreenPresentationStyle(ApphudScreenPresentationStyle.fullScreen | pageSheet)to control how Rules screens (including Figma rule paywalls) are presented on iOS.Why a separate method: the native
ApphudUIDelegate.apphudScreenPresentationStylereturns synchronously and cannot be bridged to async JS. The style is stored in the events module (same pattern assetApphudProductIdentifiers) and returned by the existing UI delegate proxy.Behavior details:
responds(to:)— SDK default behavior preserved byte-for-byte.Promiseresolves after the write.setScreenPresentationStyle(style: string): Promise<void>onNativeApphudSdkEvents; TS enumApphudScreenPresentationStyleintypes.ts.Verified:
tsc+eslintclean, codegen regenerated, example built and smoke-tested on iOS simulator (both styles visually confirmed via a temporary local trigger, not committed) and Android emulator (no-op path). Example app intentionally untouched.