fix: use ESM readline in iOS device prompt - #50
Merged
saikrishna321 merged 3 commits intoAug 4, 2026
Conversation
qmkCamel
marked this pull request as ready for review
July 31, 2026 04:17
SrinivasanTarget
approved these changes
Aug 2, 2026
中文:合并上游 PR appclawhq#51、appclawhq#52 以及 2.0.1、2.0.2 发布提交,保持 PR appclawhq#50 基于最新主分支。 English: Merge upstream PRs appclawhq#51 and appclawhq#52 plus the 2.0.1 and 2.0.2 release commits so PR appclawhq#50 is based on the latest main.
中文:仅在同仓库 PR 或手动触发时运行依赖 LLM_API_KEY 的 Android、DOM 和 Vision 检查,避免外部 PR 因拿不到仓库密钥而误报失败。 English: Run LLM_API_KEY-dependent Android, DOM, and Vision checks only for same-repository pull requests or manual dispatches so fork PRs do not fail on unavailable repository secrets.
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 4, 2026
## [2.0.3](v2.0.2...v2.0.3) (2026-08-04) ### Bug Fixes * use ESM readline in iOS device prompt ([#50](#50)) ([aee7c4d](aee7c4d))
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
require('node:readline')call in the real-device confirmation path with an ESM importWhy
@appclaw/coreis published as an ES module. When an interactive iOS real-device run reaches the WDA confirmation prompt,requireis unavailable and the CLI exits with:Non-interactive runs skip this branch, which is why CI-style flows were not affected.
Impact
Interactive flows and Playground sessions can confirm a preinstalled WDA without crashing. Non-interactive behavior is unchanged.
Verification
npm run typechecknpm run format:checknpm test— 18 test files, 364 tests passed@appclaw/cli@2.0.0on an iOS 26.2.1 real device; the WDA confirmation completed and a 4/4-step flow passed