Harden DFT and NPT capability contracts - #32
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The public configuration, readiness metadata, and canonical documentation had drifted from the implemented runtime. Variable-cell DFT settings were accepted but unused, GPCRmd classified all NPT requests as unsupported physics even though a proof-level runtime exists, and transfer tests could only obtain NPT behavior by mutating source protocol metadata. Checkpoints also lacked an explicit binding to the source-versus-validation protocol decision.
User impact
Unsupported DFT relaxation requests now fail immediately with a precise error. GPCRmd reports distinguish implementation support from missing workload certification while production readiness remains fail closed. NVT and NPT callers receive an explicit runtime entry point. Project-defined NPT validation keeps source metadata immutable and preserves the exact protocol identity across restart.
Validation
ruff check srcpassed.git diff --checkpassed.The complete local suite cannot collect in the current headless macOS sandbox because an unchanged import-time test initializes MLX Metal. Linux
mlx-cpuCI remains the routine full correctness reference.