feat: Extend diagnostics hook to async and require - #49
Merged
Conversation
isaacs
approved these changes
Jul 14, 2026
isaacs
left a comment
Contributor
There was a problem hiding this comment.
This is the correct way to do it. 👍
This was referenced Jul 14, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The async
Module.registerhooks run on a separate loader thread, so the diagnostics hook set on the main thread was never called on that path.createDiagnosticsPort()returns a MessagePort to pass toModule.registerviadata.diagnosticsPortandtransferList; the loader thread posts transform diagnostics back over it to the hook set withsetDiagnosticsHook.Module.prototype._compilepatch now emits diagnostics too, since it is what transforms CommonJS on this path.ESM diagnostics on the async path arrive asynchronously and the port does not keep the process alive.